From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=53639 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OLf5b-0002ct-AN for qemu-devel@nongnu.org; Mon, 07 Jun 2010 12:22:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OLf5Z-0006iG-9Z for qemu-devel@nongnu.org; Mon, 07 Jun 2010 12:22:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50869) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OLf5Z-0006i1-2L for qemu-devel@nongnu.org; Mon, 07 Jun 2010 12:22:13 -0400 Date: Mon, 7 Jun 2010 19:17:30 +0300 From: "Michael S. Tsirkin" Subject: Re: [Qemu-devel] [PATCH] configure: add an option to disable vlans Message-ID: <20100607161730.GB11177@redhat.com> References: <20100607150309.GA13369@redhat.com> <201006071716.31103.paul@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201006071716.31103.paul@codesourcery.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Brook Cc: qemu-devel@nongnu.org On Mon, Jun 07, 2010 at 05:16:30PM +0100, Paul Brook wrote: > > With -netdev, there now seems to be little need to support vlans, > > enabling them leads to user confusion and bad performance. > > Disable support for vlans by default, add config option to enable. > > No. If you want to remove vlans, then actually do that. How is this not what this patch does? You mean kill the code completely, not just --contigure option? > As I've said before if you want a point-point network model then you should > implement that (and remove the vlan code, probably replacing with equivalent > functionality). We should not have both point-point and broadcast interfaces. > > Paul This is what netdev does: replaces vlan. What is left is remove vlan. -- MST