From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=42306 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OLexT-0004Kr-Ea for qemu-devel@nongnu.org; Mon, 07 Jun 2010 12:13:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OLexS-0005MI-DK for qemu-devel@nongnu.org; Mon, 07 Jun 2010 12:13:51 -0400 Received: from mail.codesourcery.com ([38.113.113.100]:57339) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OLexS-0005M6-4U for qemu-devel@nongnu.org; Mon, 07 Jun 2010 12:13:50 -0400 From: Paul Brook Subject: Re: [Qemu-devel] [PATCH] Fix and simplify gui timer logic. Date: Mon, 7 Jun 2010 17:12:51 +0100 References: <1275659074-4516-1-git-send-email-kraxel@redhat.com> In-Reply-To: <1275659074-4516-1-git-send-email-kraxel@redhat.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201006071712.52267.paul@codesourcery.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Gerd Hoffmann > Kill nographic timer. Have a global gui_timer instead. Have the gui > timer enabled unconditionally. We need a timer running anyway for mmio > flush, so the whole have-gui-timer-only-when-needed logic is pretty > pointless. It also simplifies displaylisteners coming and going at > runtime, we don't need to care about the timer then as it runs anyway. Linking mmio flushes to the gui is completely bogus. The fact that we're doing arbitrary periodic mmio flushes suggests something else is horribly broken. Paul