From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=52695 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OLhCZ-0001qw-H9 for qemu-devel@nongnu.org; Mon, 07 Jun 2010 14:37:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OLhCU-0000TL-MM for qemu-devel@nongnu.org; Mon, 07 Jun 2010 14:37:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:31360) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OLhCU-0000T4-EC for qemu-devel@nongnu.org; Mon, 07 Jun 2010 14:37:30 -0400 Date: Mon, 7 Jun 2010 20:41:40 +0300 From: "Michael S. Tsirkin" Subject: Re: [Qemu-devel] [PATCH] configure: add an option to disable vlans Message-ID: <20100607174140.GE11177@redhat.com> References: <20100607150309.GA13369@redhat.com> <201006071716.31103.paul@codesourcery.com> <20100607161730.GB11177@redhat.com> <201006071742.56312.paul@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201006071742.56312.paul@codesourcery.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Brook Cc: qemu-devel@nongnu.org On Mon, Jun 07, 2010 at 05:42:55PM +0100, Paul Brook wrote: > > On Mon, Jun 07, 2010 at 05:16:30PM +0100, Paul Brook wrote: > > > > With -netdev, there now seems to be little need to support vlans, > > > > enabling them leads to user confusion and bad performance. > > > > Disable support for vlans by default, add config option to enable. > > > > > > No. If you want to remove vlans, then actually do that. > > > > How is this not what this patch does? You mean kill the code > > completely, not just --contigure option? > > Yes. Configure options are bad. If code isn't worth enabling by default then > you've got to have a very good reason why it exists at all. > > Paul Everyone ok with disabling vlans with no config option? -- MST