From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=42546 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OLfQZ-000457-Lw for qemu-devel@nongnu.org; Mon, 07 Jun 2010 12:43:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OLfQW-00029A-1E for qemu-devel@nongnu.org; Mon, 07 Jun 2010 12:43:54 -0400 Received: from mail.codesourcery.com ([38.113.113.100]:34948) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OLfQV-00028a-Mm for qemu-devel@nongnu.org; Mon, 07 Jun 2010 12:43:51 -0400 From: Paul Brook Subject: Re: [Qemu-devel] [PATCH] configure: add an option to disable vlans Date: Mon, 7 Jun 2010 17:42:55 +0100 References: <20100607150309.GA13369@redhat.com> <201006071716.31103.paul@codesourcery.com> <20100607161730.GB11177@redhat.com> In-Reply-To: <20100607161730.GB11177@redhat.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201006071742.56312.paul@codesourcery.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org > On Mon, Jun 07, 2010 at 05:16:30PM +0100, Paul Brook wrote: > > > With -netdev, there now seems to be little need to support vlans, > > > enabling them leads to user confusion and bad performance. > > > Disable support for vlans by default, add config option to enable. > > > > No. If you want to remove vlans, then actually do that. > > How is this not what this patch does? You mean kill the code > completely, not just --contigure option? Yes. Configure options are bad. If code isn't worth enabling by default then you've got to have a very good reason why it exists at all. Paul