From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=52081 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OLhxF-0005sA-1j
	for qemu-devel@nongnu.org; Mon, 07 Jun 2010 15:25:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <mst@redhat.com>) id 1OLhxD-0000R4-Ph
	for qemu-devel@nongnu.org; Mon, 07 Jun 2010 15:25:48 -0400
Received: from mx1.redhat.com ([209.132.183.28]:28467)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <mst@redhat.com>) id 1OLhxD-0000Qk-Hw
	for qemu-devel@nongnu.org; Mon, 07 Jun 2010 15:25:47 -0400
Date: Mon, 7 Jun 2010 22:21:00 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] configure: add an option to disable vlans
Message-ID: <20100607192059.GA14490@redhat.com>
References: <20100607150309.GA13369@redhat.com>
	<201006071716.31103.paul@codesourcery.com>
	<20100607161730.GB11177@redhat.com>
	<201006071742.56312.paul@codesourcery.com>
	<4C0D23B5.3050605@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4C0D23B5.3050605@codemonkey.ws>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Paul Brook <paul@codesourcery.com>, qemu-devel@nongnu.org

On Mon, Jun 07, 2010 at 11:52:05AM -0500, Anthony Liguori wrote:
> On 06/07/2010 11:42 AM, Paul Brook wrote:
>>> On Mon, Jun 07, 2010 at 05:16:30PM +0100, Paul Brook wrote:
>>>      
>>>>> With -netdev, there now seems to be little need to support vlans,
>>>>> enabling them leads to user confusion and bad performance.
>>>>> Disable support for vlans by default, add config option to enable.
>>>>>          
>>>> No. If you want to remove vlans, then actually do that.
>>>>        
>>> How is this not what this patch does?  You mean kill the code
>>> completely, not just --contigure option?
>>>      
>> Yes. Configure options are bad. If code isn't worth enabling by default then
>> you've got to have a very good reason why it exists at all.
>>    
>
> Configure options are bad except when they are good.
>
> Distributions don't want to support every possible bell and whistle that  
> qemu supports.  By having configuration options upstream, we ensure that  
> everyone is consistently disabling thing in the same fashion and that  
> the interfaces presented to the users are consistent.
>
> I certainly believe that we should not disable features by default.  But  
> I think it's important that we support disabling features from a  
> downstream supportability perspective.
>
> Regards,
>
> Anthony Liguori

So I see two ways to go forward: switch default value in my patch,
or disable vlans unconditionally.

Which will it be?

>> Paul
>>
>>