From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=57986 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OLnCf-0006cX-Hw
	for qemu-devel@nongnu.org; Mon, 07 Jun 2010 21:02:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <paul@codesourcery.com>) id 1OLnCe-0002fD-DB
	for qemu-devel@nongnu.org; Mon, 07 Jun 2010 21:02:05 -0400
Received: from mail.codesourcery.com ([38.113.113.100]:41503)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <paul@codesourcery.com>) id 1OLnCe-0002ez-2x
	for qemu-devel@nongnu.org; Mon, 07 Jun 2010 21:02:04 -0400
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH 15/22] machine: make max_cpus a -machine
	option
Date: Tue, 8 Jun 2010 02:01:07 +0100
References: <1275954730-8196-1-git-send-email-aliguori@us.ibm.com>
	<1275954730-8196-16-git-send-email-aliguori@us.ibm.com>
In-Reply-To: <1275954730-8196-16-git-send-email-aliguori@us.ibm.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Message-Id: <201006080201.08018.paul@codesourcery.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Anthony Liguori <aliguori@us.ibm.com>, Glauber Costa <glommer@redhat.com>

> diff --git a/hw/realview.c b/hw/realview.c
> index a36bdbe..8dcef80 100644
> --- a/hw/realview.c
> +++ b/hw/realview.c
> @@ -444,9 +444,9 @@ static QEMUMachine realview_eb_mpcore_machine = {
>      .init = realview_eb_mpcore_init,
>      .opts_default = (QemuOptValue[]) {
>          QOPT_VALUE("default_drive", "scsi"),
> +        QOPT_VALUE("max_cpus", "4"),
>          { /* end of list */ }
>      },
> -    .max_cpus = 4,
>  };

By my reading this allows the user to modify this value. If so it is wrong. 

This is a fundamental property/limitation of the hardware. Expect qemu to 
crash if the value is modified.

Paul