From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=59575 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OLuY6-00033F-Jk for qemu-devel@nongnu.org; Tue, 08 Jun 2010 04:52:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OLuY2-00048a-90 for qemu-devel@nongnu.org; Tue, 08 Jun 2010 04:52:42 -0400 Received: from verein.lst.de ([213.95.11.210]:47120) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OLuY1-000480-VD for qemu-devel@nongnu.org; Tue, 08 Jun 2010 04:52:38 -0400 Date: Tue, 8 Jun 2010 10:52:34 +0200 From: Christoph Hellwig Subject: Re: [Qemu-devel] [PATCH 3/3] cow: use qemu block API Message-ID: <20100608085234.GA25951@lst.de> References: <20100607100647.GC2176@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org On Mon, Jun 07, 2010 at 02:27:40PM +0200, Markus Armbruster wrote: > Christoph Hellwig writes: > > > Use bdrv_pwrite to access the backing device instead of pread, and > > convert the driver to implementing the bdrv_open method which gives > > it an already opened BlockDriverState for the underlying device. > > > > Signed-off-by: Christoph Hellwig > > In my (admittedly limited) understanding, we need this for sane protocol > handling in -blockdev & friends. Yes - not just in -blockdev but also in general.