From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=49292 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OLzfJ-00023C-Bs for qemu-devel@nongnu.org; Tue, 08 Jun 2010 10:20:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OLzfF-0007l9-1h for qemu-devel@nongnu.org; Tue, 08 Jun 2010 10:20:26 -0400 Received: from mail.valinux.co.jp ([210.128.90.3]:44874) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OLzfE-0007kO-H5 for qemu-devel@nongnu.org; Tue, 08 Jun 2010 10:20:25 -0400 Date: Tue, 8 Jun 2010 23:16:48 +0900 From: Isaku Yamahata Subject: Re: [Qemu-devel] [PATCH] Clarify error message when a PCI slot is already in use Message-ID: <20100608141648.GA23473@valinux.co.jp> References: <1276005505-29689-1-git-send-email-berrange@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1276005505-29689-1-git-send-email-berrange@redhat.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: qemu-devel@nongnu.org On Tue, Jun 08, 2010 at 02:58:25PM +0100, Daniel P. Berrange wrote: > When mistakenly configuring two devices in the same PCI slot, > QEMU gives a not entirely obvious message about a 'devfn' being > in use: > > $ qemu -device rtl8139 -device virtio-balloon-pci,bus=pci.0,addr=0x3 > qemu-kvm: -device virtio-balloon-pci,bus=pci.0,addr=0x3: PCI: devfn 24 not available for virtio-balloon-pci, in use by rtl8139 > > The user does not configure 'devfn' numbers, they use slot+function. > Thus the error messages should be reported back to the user with that > same terminology rather than the internal QEMU terminology. This > patch makes it report: > > $ qemu -device rtl8139 -device virtio-balloon-pci,bus=pci.0,addr=0x3 > qemu: -device virtio-balloon-pci,bus=pci.0,addr=0x3.7: PCI: slot 3 function 0 not available for virtio-balloon-pci, in use by rtl8139 > > Signed-off-by: Daniel P. Berrange > --- > hw/pci.c | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/hw/pci.c b/hw/pci.c > index cbbd1dd..2347708 100644 > --- a/hw/pci.c > +++ b/hw/pci.c > @@ -609,12 +609,12 @@ static PCIDevice *do_pci_register_device(PCIDevice *pci_dev, PCIBus *bus, > if (!bus->devices[devfn]) > goto found; > } > - error_report("PCI: no devfn available for %s, all in use", name); > + error_report("PCI: no slot/function available for %s, all in use", name); > return NULL; > found: ; > } else if (bus->devices[devfn]) { > - error_report("PCI: devfn %d not available for %s, in use by %s", > - devfn, name, bus->devices[devfn]->name); > + error_report("PCI: slot %d function %d not available for %s, in use by %s", > + (devfn >> 3), (devfn % 8), name, bus->devices[devfn]->name); Please use PCI_SLOT() and PCI_FUNC(). > return NULL; > } > pci_dev->bus = bus; > -- > 1.6.6.1 > > -- yamahata