From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=60224 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OLzxu-0002LC-Av for qemu-devel@nongnu.org; Tue, 08 Jun 2010 10:39:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OLzxm-000355-Eh for qemu-devel@nongnu.org; Tue, 08 Jun 2010 10:39:42 -0400 Received: from mail.codesourcery.com ([38.113.113.100]:40384) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OLzxm-00034s-77 for qemu-devel@nongnu.org; Tue, 08 Jun 2010 10:39:34 -0400 From: Paul Brook Subject: Re: [Qemu-devel] Re: [PATCH 01/22] QemuOpts: fix a bug in QemuOpts when setting an option twice Date: Tue, 8 Jun 2010 15:38:37 +0100 References: <1275954730-8196-1-git-send-email-aliguori@us.ibm.com> <4C0E1C3B.9020701@redhat.com> <4C0E4096.9020705@codemonkey.ws> In-Reply-To: <4C0E4096.9020705@codemonkey.ws> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201006081538.38232.paul@codesourcery.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Glauber Costa , Gerd Hoffmann > The problem I was trying to address can be seen with something like: > > -drive file=foo.img,if=virtio,file=bar.img > > You get no error, and foo.img is what gets used. It's fair to argue > this is a silly use case but what I'm trying to achieve is to make it > possible to do: > > -drive file=foo.img,if=virtio,id=bar -drive file=bar.img,id=bar IMO these should both behave consistently. I'd prefer that both of are errors. Paul