From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=43836 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OM25K-0000SO-OG
	for qemu-devel@nongnu.org; Tue, 08 Jun 2010 12:55:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <amit.shah@redhat.com>) id 1OM25F-0004pu-Iq
	for qemu-devel@nongnu.org; Tue, 08 Jun 2010 12:55:30 -0400
Received: from mx1.redhat.com ([209.132.183.28]:56201)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <amit.shah@redhat.com>) id 1OM25F-0004pa-Bk
	for qemu-devel@nongnu.org; Tue, 08 Jun 2010 12:55:25 -0400
Received: from int-mx05.intmail.prod.int.phx2.redhat.com
	(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o58GtLQO004939
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Tue, 8 Jun 2010 12:55:24 -0400
Date: Tue, 8 Jun 2010 22:10:58 +0530
From: Amit Shah <amit.shah@redhat.com>
Message-ID: <20100608164029.GA10305@amit-laptop.redhat.com>
References: <96e6e74c3b7adc90d57e1303cd09d272bc9f7e06.1276010252.git.amit.shah@redhat.com>
	<4C0E6238.5090308@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4C0E6238.5090308@redhat.com>
Subject: [Qemu-devel] Re: [PATCH] net: Fix hotplug with pci_add
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Juan Quintela <quintela@redhat.com>, qemu list <qemu-devel@nongnu.org>, Markus Armbruster <armbru@redhat.com>

On (Tue) Jun 08 2010 [17:31:04], Gerd Hoffmann wrote:
> On 06/08/10 17:17, Amit Shah wrote:
> >The correct model type wasn't getting added when hotplugging nics with
> >pci_add.
> >
> >Testcase: start VM with default nic type. In the qemu_monitor:
> >
> >(qemu) pci_add auto nic model=virtio
> >
> >This results in a nic hot-plug of the same nic type as the default.
> 
> Same goes for mac address and vlan btw, most likely for the same
> reason.  I guess your patch handles this too?

Yes, all the properties.

		Amit