From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=52878 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OM6hU-0006f1-E1
	for qemu-devel@nongnu.org; Tue, 08 Jun 2010 17:51:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <chrisw@redhat.com>) id 1OM6hT-00031q-Ds
	for qemu-devel@nongnu.org; Tue, 08 Jun 2010 17:51:12 -0400
Received: from mx1.redhat.com ([209.132.183.28]:41753)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <chrisw@redhat.com>) id 1OM6hT-00031e-5P
	for qemu-devel@nongnu.org; Tue, 08 Jun 2010 17:51:11 -0400
Date: Tue, 8 Jun 2010 14:51:07 -0700
From: Chris Wright <chrisw@redhat.com>
Message-ID: <20100608215107.GU28492@x200.localdomain>
References: <20100608191447.4451.47795.stgit@localhost.localdomain>
	<20100608191535.4451.48702.stgit@localhost.localdomain>
	<20100608212659.GS28492@x200.localdomain>
	<1276033548.3079.20.camel@x201>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1276033548.3079.20.camel@x201>
Subject: [Qemu-devel] Re: [RFC PATCH 2/6] ram_blocks: Convert to a QLIST
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: Chris Wright <chrisw@redhat.com>, quintela@redhat.com, qemu-devel@nongnu.org, kvm@vger.kernel.org

* Alex Williamson (alex.williamson@redhat.com) wrote:
> On Tue, 2010-06-08 at 14:26 -0700, Chris Wright wrote:
> > * Alex Williamson (alex.williamson@redhat.com) wrote:
> > >  extern int phys_ram_fd;
> > > -extern uint8_t *phys_ram_dirty;
> > >  extern ram_addr_t ram_size;
> > > -extern ram_addr_t last_ram_offset;
> > > +
> > > +typedef struct RAMBlock {
> > > +    uint8_t *host;
> > > +    ram_addr_t offset;
> > > +    ram_addr_t length;
> > > +    QLIST_ENTRY(RAMBlock) next;
> > > +} RAMBlock;
> > > +
> > > +typedef struct RAMList {
> > > +    uint8_t *phys_dirty;
> > > +    ram_addr_t last_offset;
> > > +    QLIST_HEAD(ram, RAMBlock) blocks;
> > > +} RAMList;
> > > +extern RAMList ram;
> > 
> > such a generic name for global namespace
> 
> Well it is _the_ ram, but yea... ;)  Suggestions?

_the_ram

/me ducks