From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=45993 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OMBRb-0007iD-H5
	for qemu-devel@nongnu.org; Tue, 08 Jun 2010 22:55:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <paul@codesourcery.com>) id 1OMBRZ-0000UM-Da
	for qemu-devel@nongnu.org; Tue, 08 Jun 2010 22:55:07 -0400
Received: from mail.codesourcery.com ([38.113.113.100]:58980)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <paul@codesourcery.com>) id 1OMBRZ-0000UF-2g
	for qemu-devel@nongnu.org; Tue, 08 Jun 2010 22:55:05 -0400
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [RFC PATCH 3/6] RAMBlock: Add a name field
Date: Wed, 9 Jun 2010 03:54:02 +0100
References: <20100608191447.4451.47795.stgit@localhost.localdomain>
	<201006090330.10324.paul@codesourcery.com>
	<4C0EFF39.9070602@codemonkey.ws>
In-Reply-To: <4C0EFF39.9070602@codemonkey.ws>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <201006090354.05197.paul@codesourcery.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: chrisw@redhat.com, Alex Williamson <alex.williamson@redhat.com>, qemu-devel@nongnu.org, kvm@vger.kernel.org, quintela@redhat.com

> On 06/08/2010 09:30 PM, Paul Brook wrote:
> >> The offset given to a block created via qemu_ram_alloc/map() is
> >> arbitrary, let the caller specify a name so we can make a positive
> >> match.
> >> 
> >> 
> >> @@ -1924,7 +1925,9 @@ static int pci_add_option_rom(PCIDevice *pdev)
> >> +    snprintf(name, sizeof(name), "pci:%02x.%x.rom",
> >> +             PCI_SLOT(pdev->devfn), PCI_FUNC(pdev->devfn));
> >> +    pdev->rom_offset = qemu_ram_alloc(name, size);
> > 
> > This looks pretty bogus.  It should be associated with the device, rather
> > than incorrectly trying to generate a globally unique name.
> 
> Not all ram is associated with a device.

Maybe not, but where it is we should be using that information.
Absolute minimum we should be using the existing qdev address rather than 
inventing a new one.  Duplicating this logic inside every device seems like a 
bad idea so I suggest identifying ram blocks by a (name, device) pair. For now 
we can allow a NULL device for system memory.

Paul