From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=48966 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OMKID-0002fA-O2
	for qemu-devel@nongnu.org; Wed, 09 Jun 2010 08:22:10 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <paul@codesourcery.com>) id 1OMKG6-0002fg-TJ
	for qemu-devel@nongnu.org; Wed, 09 Jun 2010 08:20:40 -0400
Received: from mail.codesourcery.com ([38.113.113.100]:44986)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <paul@codesourcery.com>) id 1OMKG6-0002dZ-Hs
	for qemu-devel@nongnu.org; Wed, 09 Jun 2010 08:19:50 -0400
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [RFC PATCH 3/6] RAMBlock: Add a name field
Date: Wed, 9 Jun 2010 13:18:47 +0100
References: <20100608191447.4451.47795.stgit@localhost.localdomain>
	<201006090354.05197.paul@codesourcery.com>
	<1276057143.3079.57.camel@x201>
In-Reply-To: <1276057143.3079.57.camel@x201>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <201006091318.49556.paul@codesourcery.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: chrisw@redhat.com, quintela@redhat.com, qemu-devel@nongnu.org, kvm@vger.kernel.org

> > > Not all ram is associated with a device.
> > 
> > Maybe not, but where it is we should be using that information.
> > Absolute minimum we should be using the existing qdev address rather than
> > inventing a new one.  Duplicating this logic inside every device seems
> > like a bad idea so I suggest identifying ram blocks by a (name, device)
> > pair. For now we can allow a NULL device for system memory.
> 
> I'm not sure if this is what you're after, but what if we change it to
> something like:
> 
> +    snprintf(name, sizeof(name), "%s.%02x.%x.rom-%s",
> +             pdev->bus->qbus.name, PCI_SLOT(pdev->devfn),
> +             PCI_FUNC(pdev->devfn), pdev->qdev.info->name);
> 
> This gives us things like "pci.0.03.0.rom-rtl8139".  For pci-assign, we
> can expand on the host details, such as:
> ..
> Giving us "pci.0.04.0.bar0-pci-assign(0000:01:10.0)".  Anywhere closer?

Not really.  This identifier is device and bus independent, which is why I 
suggested passing the device to qemu_ram_alloc.  This can then figure out how 
to the identify the device. It should probably do this the same way that we 
identify the saved state for the device.  Currently I think this is an 
arbitrary vmstate name/id, but I expect this to change to a qdev address
(e.g. /i440FX-pcihost/pci.0/_addr_04.0").

Paul