From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=51299 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OMNN1-0008JD-P3
	for qemu-devel@nongnu.org; Wed, 09 Jun 2010 11:39:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <froydnj@codesourcery.com>) id 1OMNN0-0002ZI-Kk
	for qemu-devel@nongnu.org; Wed, 09 Jun 2010 11:39:11 -0400
Received: from mail.codesourcery.com ([38.113.113.100]:56868)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <froydnj@codesourcery.com>) id 1OMNN0-0002Yt-D3
	for qemu-devel@nongnu.org; Wed, 09 Jun 2010 11:39:10 -0400
Date: Wed, 9 Jun 2010 08:39:08 -0700
From: Nathan Froyd <froydnj@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH 0/8] target-mips: add microMIPS ASE
	support, v3
Message-ID: <20100609153908.GV19235@codesourcery.com>
References: <1276029003-10158-1-git-send-email-froydnj@codesourcery.com>
	<20100609141025.GE26968@volta.aurel32.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20100609141025.GE26968@volta.aurel32.net>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: qemu-devel@nongnu.org

On Wed, Jun 09, 2010 at 04:10:25PM +0200, Aurelien Jarno wrote:
> On Tue, Jun 08, 2010 at 01:29:55PM -0700, Nathan Froyd wrote:
> > This patch series adds support for the microMIPS ASE.  microMIPS is a
> > new ASE similar to MIPS16, but re-encodes the entire instruction set
> > into 16-bit and 32-bit instructions--in contrast to MIPS16, which
> > re-encodes only integer instructions.  The mechanisms for going in and
> > out of microMIPS mode are identical to those for MIPS16; a given chip
> > cannot support both ASEs simultaneously.
> 
> I have applied all patches except the 5th one, see my comments about
> it.

Thanks for applying these.  I agree with you about the 5th one and will
submit a M14K patch in the next week.

> Finally, I have made some comments about the 4th patch, that may be a
> basis for future improvements.

Indeed.  I will work on that one.

-Nathan