qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paul Brook <paul@codesourcery.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: chrisw@redhat.com, quintela@redhat.com, qemu-devel@nongnu.org,
	kvm@vger.kernel.org
Subject: Re: [Qemu-devel] [RFC PATCH 3/6] RAMBlock: Add a name field
Date: Wed, 9 Jun 2010 21:36:36 +0100	[thread overview]
Message-ID: <201006092136.38569.paul@codesourcery.com> (raw)
In-Reply-To: <1276101449.3079.74.camel@x201>

> > Not really.  This identifier is device and bus independent, which is why
> > I suggested passing the device to qemu_ram_alloc.  This can then figure
> > out how to the identify the device. It should probably do this the same
> > way that we identify the saved state for the device.  Currently I think
> > this is an arbitrary vmstate name/id, but I expect this to change to a
> > qdev address (e.g. /i440FX-pcihost/pci.0/_addr_04.0").
> 
> Ok, that seems fairly reasonable, so from a device pointer we can get
> something like "/i440FX-pcihost/pci.0/_addr_04.0", then we can add
> something like ":rom" or ":bar.0" to it via an extra string.
> 
> qemu_ram_alloc(DeviceState *dev, const char *info, size)

Exactly - though personally I wouldn't call the second argument "info".
 
> Does a function already exist to print out a qdev address path?

No.

I may have been a bit misleading here. What we really want to do is use the 
same matching algorithm as is used by the rest of the device state. Currently 
this is a vmstate name and [arbitrary] numeric id. I don't remember whether 
there's a convenient link from a device to its associated vmstate - if there 
isn't there probably should be.

Paul

  reply	other threads:[~2010-06-09 20:37 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-08 19:14 [Qemu-devel] [RFC PATCH 0/6] RAM migration overhaul Alex Williamson
2010-06-08 19:15 ` [Qemu-devel] [RFC PATCH 1/6] qemu_ram_alloc: Remove duplicate code Alex Williamson
2010-06-08 21:00   ` [Qemu-devel] " Chris Wright
2010-06-08 19:15 ` [Qemu-devel] [RFC PATCH 2/6] ram_blocks: Convert to a QLIST Alex Williamson
2010-06-08 21:26   ` [Qemu-devel] " Chris Wright
2010-06-08 21:45     ` Alex Williamson
2010-06-08 21:51       ` Chris Wright
2010-06-09  8:19       ` Juan Quintela
2010-06-09 20:11   ` [Qemu-devel] " Cam Macdonell
2010-06-09 20:55     ` Alex Williamson
2010-06-09 21:12       ` Yoshiaki Tamura
2010-06-08 19:15 ` [Qemu-devel] [RFC PATCH 3/6] RAMBlock: Add a name field Alex Williamson
2010-06-08 20:07   ` [Qemu-devel] " Anthony Liguori
2010-06-08 20:09     ` Alex Williamson
2010-06-08 21:41   ` Chris Wright
2010-06-09  3:13     ` Alex Williamson
2010-06-09 11:55     ` Avi Kivity
2010-06-09 12:56     ` Paul Brook
2010-06-09  2:30   ` [Qemu-devel] " Paul Brook
2010-06-09  2:40     ` Anthony Liguori
2010-06-09  2:54       ` Paul Brook
2010-06-09  4:19         ` Alex Williamson
2010-06-09 12:18           ` Paul Brook
2010-06-09 16:37             ` Alex Williamson
2010-06-09 20:36               ` Paul Brook [this message]
2010-06-10  8:23                 ` Gerd Hoffmann
2010-06-10 14:33                   ` Alex Williamson
2010-06-10 14:49                     ` Paul Brook
2010-06-10 15:21                       ` Alex Williamson
2010-06-11  8:48                         ` Gerd Hoffmann
2010-06-11 15:50                           ` Alex Williamson
2010-06-11 16:12                             ` Paul Brook
2010-06-11  8:45                     ` Gerd Hoffmann
2010-06-10 15:05                 ` Alex Williamson
2010-06-10 16:40               ` Chris Wright
2010-06-10 16:45                 ` Paul Brook
2010-06-09 11:58         ` Avi Kivity
2010-06-09 13:57           ` Anthony Liguori
2010-06-09 14:09             ` Paul Brook
2010-06-09  7:28       ` Gerd Hoffmann
2010-06-08 19:16 ` [Qemu-devel] [RFC PATCH 4/6] Remove uses of ram.last_offset (aka last_ram_offset) Alex Williamson
2010-06-08 19:16 ` [Qemu-devel] [RFC PATCH 5/6] savevm: Migrate RAM based on name/offset Alex Williamson
2010-06-08 20:12   ` [Qemu-devel] " Anthony Liguori
2010-06-08 21:12     ` Alex Williamson
2010-06-08 20:54   ` Chris Wright
2010-06-08 21:22     ` Alex Williamson
2010-06-08 19:16 ` [Qemu-devel] [RFC PATCH 6/6] savevm: Use RAM blocks for basis of migration Alex Williamson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201006092136.38569.paul@codesourcery.com \
    --to=paul@codesourcery.com \
    --cc=alex.williamson@redhat.com \
    --cc=chrisw@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).