From: Paul Brook <paul@codesourcery.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: chrisw@redhat.com, kvm@vger.kernel.org, quintela@redhat.com,
qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [Qemu-devel] [RFC PATCH 3/6] RAMBlock: Add a name field
Date: Thu, 10 Jun 2010 15:49:13 +0100 [thread overview]
Message-ID: <201006101549.14094.paul@codesourcery.com> (raw)
In-Reply-To: <1276180408.2992.12.camel@x201>
> On Thu, 2010-06-10 at 10:23 +0200, Gerd Hoffmann wrote:
> > > I may have been a bit misleading here. What we really want to do is use
> > > the same matching algorithm as is used by the rest of the device
> > > state. Currently this is a vmstate name and [arbitrary] numeric id. I
> > > don't remember whether there's a convenient link from a device to its
> > > associated vmstate - if there isn't there probably should be.
> >
> > DeviceState->info->vmsd->name for the name.
> > Dunno about the numeric id, I think savevm.c doesn't export it.
>
> Ok, we can certainly do <vmsd->name>.<vmsd->instance>\<driver string>.
> It seems like this highlights a deficiency in the vmstate matching
Why are you forcing this to be a string?
> Then we start the target, ordering the nics sequentially, are we going
> to store the vmstate into the opposite nics?
That's a separate problem. As long as you use the same matching as for the
rest of the device state then it should just work. If it doesn't work then
migration is already broken so it doen't matter.
Paul
next prev parent reply other threads:[~2010-06-10 14:50 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-08 19:14 [Qemu-devel] [RFC PATCH 0/6] RAM migration overhaul Alex Williamson
2010-06-08 19:15 ` [Qemu-devel] [RFC PATCH 1/6] qemu_ram_alloc: Remove duplicate code Alex Williamson
2010-06-08 21:00 ` [Qemu-devel] " Chris Wright
2010-06-08 19:15 ` [Qemu-devel] [RFC PATCH 2/6] ram_blocks: Convert to a QLIST Alex Williamson
2010-06-08 21:26 ` [Qemu-devel] " Chris Wright
2010-06-08 21:45 ` Alex Williamson
2010-06-08 21:51 ` Chris Wright
2010-06-09 8:19 ` Juan Quintela
2010-06-09 20:11 ` [Qemu-devel] " Cam Macdonell
2010-06-09 20:55 ` Alex Williamson
2010-06-09 21:12 ` Yoshiaki Tamura
2010-06-08 19:15 ` [Qemu-devel] [RFC PATCH 3/6] RAMBlock: Add a name field Alex Williamson
2010-06-08 20:07 ` [Qemu-devel] " Anthony Liguori
2010-06-08 20:09 ` Alex Williamson
2010-06-08 21:41 ` Chris Wright
2010-06-09 3:13 ` Alex Williamson
2010-06-09 11:55 ` Avi Kivity
2010-06-09 12:56 ` Paul Brook
2010-06-09 2:30 ` [Qemu-devel] " Paul Brook
2010-06-09 2:40 ` Anthony Liguori
2010-06-09 2:54 ` Paul Brook
2010-06-09 4:19 ` Alex Williamson
2010-06-09 12:18 ` Paul Brook
2010-06-09 16:37 ` Alex Williamson
2010-06-09 20:36 ` Paul Brook
2010-06-10 8:23 ` Gerd Hoffmann
2010-06-10 14:33 ` Alex Williamson
2010-06-10 14:49 ` Paul Brook [this message]
2010-06-10 15:21 ` Alex Williamson
2010-06-11 8:48 ` Gerd Hoffmann
2010-06-11 15:50 ` Alex Williamson
2010-06-11 16:12 ` Paul Brook
2010-06-11 8:45 ` Gerd Hoffmann
2010-06-10 15:05 ` Alex Williamson
2010-06-10 16:40 ` Chris Wright
2010-06-10 16:45 ` Paul Brook
2010-06-09 11:58 ` Avi Kivity
2010-06-09 13:57 ` Anthony Liguori
2010-06-09 14:09 ` Paul Brook
2010-06-09 7:28 ` Gerd Hoffmann
2010-06-08 19:16 ` [Qemu-devel] [RFC PATCH 4/6] Remove uses of ram.last_offset (aka last_ram_offset) Alex Williamson
2010-06-08 19:16 ` [Qemu-devel] [RFC PATCH 5/6] savevm: Migrate RAM based on name/offset Alex Williamson
2010-06-08 20:12 ` [Qemu-devel] " Anthony Liguori
2010-06-08 21:12 ` Alex Williamson
2010-06-08 20:54 ` Chris Wright
2010-06-08 21:22 ` Alex Williamson
2010-06-08 19:16 ` [Qemu-devel] [RFC PATCH 6/6] savevm: Use RAM blocks for basis of migration Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201006101549.14094.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=alex.williamson@redhat.com \
--cc=chrisw@redhat.com \
--cc=kraxel@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).