From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=35155 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OMkny-0001Zv-Bl for qemu-devel@nongnu.org; Thu, 10 Jun 2010 12:40:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OMknx-0000cd-DE for qemu-devel@nongnu.org; Thu, 10 Jun 2010 12:40:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:64928) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OMknx-0000c4-6T for qemu-devel@nongnu.org; Thu, 10 Jun 2010 12:40:33 -0400 Date: Thu, 10 Jun 2010 09:40:16 -0700 From: Chris Wright Subject: Re: [Qemu-devel] [RFC PATCH 3/6] RAMBlock: Add a name field Message-ID: <20100610164016.GG14393@x200.localdomain> References: <20100608191447.4451.47795.stgit@localhost.localdomain> <201006090354.05197.paul@codesourcery.com> <1276057143.3079.57.camel@x201> <201006091318.49556.paul@codesourcery.com> <1276101449.3079.74.camel@x201> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1276101449.3079.74.camel@x201> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Williamson Cc: chrisw@redhat.com, kvm@vger.kernel.org, quintela@redhat.com, qemu-devel@nongnu.org, Paul Brook * Alex Williamson (alex.williamson@redhat.com) wrote: > On Wed, 2010-06-09 at 13:18 +0100, Paul Brook wrote: > > to the identify the device. It should probably do this the same way that we > > identify the saved state for the device. Currently I think this is an > > arbitrary vmstate name/id, but I expect this to change to a qdev address > > (e.g. /i440FX-pcihost/pci.0/_addr_04.0"). > > Ok, that seems fairly reasonable, so from a device pointer we can get > something like "/i440FX-pcihost/pci.0/_addr_04.0", then we can add > something like ":rom" or ":bar.0" to it via an extra string. In the fun game of what ifs... The cmdline starts w/ device A placed at pci bus addr 00:04.0 (so matched on source and target). The source does hotunplug of 04.0 and replaces it w/ new device. I think we need something that is more uniquely identifying the block. Not sure that device name is correct or a generation ID. thanks, -chris