From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=50922 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OMnP6-0004aZ-29 for qemu-devel@nongnu.org; Thu, 10 Jun 2010 15:27:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OMnEY-0001fM-Gh for qemu-devel@nongnu.org; Thu, 10 Jun 2010 15:16:11 -0400 Received: from e28smtp08.in.ibm.com ([122.248.162.8]:47477) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OMnEX-0001f2-OJ for qemu-devel@nongnu.org; Thu, 10 Jun 2010 15:16:10 -0400 Received: from d28relay05.in.ibm.com (d28relay05.in.ibm.com [9.184.220.62]) by e28smtp08.in.ibm.com (8.14.4/8.13.1) with ESMTP id o5AI944n031063 for ; Thu, 10 Jun 2010 23:39:04 +0530 Received: from d28av05.in.ibm.com (d28av05.in.ibm.com [9.184.220.67]) by d28relay05.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o5AJG3ms3436552 for ; Fri, 11 Jun 2010 00:46:05 +0530 Received: from d28av05.in.ibm.com (loopback [127.0.0.1]) by d28av05.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id o5AJG3Rk031084 for ; Fri, 11 Jun 2010 05:16:03 +1000 Date: Fri, 11 Jun 2010 00:45:58 +0530 From: Prerna Saxena Message-ID: <20100611004558.7d87f0e5@zephyr> In-Reply-To: <20100611003811.2635fa5d@zephyr> References: <20100611003811.2635fa5d@zephyr> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] [RFC v2] [PATCH 1/3] Export tdb_hash() List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Anthony Liguori , Stefan Hajnoczi , kvm@vger.kernel.org, Jan Kiszka , Luiz Capitulino , maneesh@linux.vnet.ibm.com, ananth@linux.vnet.ibm.com For now, I simply export tdb_hash() from qdict.h for use by tracing framework. Luiz suggested renaming and exporting it from a location other than qdict.h . Would "qemu-common.h" be a better place? Signed-off-by: Prerna Saxena --- qdict.c | 2 +- qdict.h | 2 ++ 2 files changed, 3 insertions(+), 1 deletions(-) diff --git a/qdict.c b/qdict.c index 175bc17..5261872 100644 --- a/qdict.c +++ b/qdict.c @@ -56,7 +56,7 @@ QDict *qobject_to_qdict(const QObject *obj) * tdb_hash(): based on the hash agorithm from gdbm, via tdb * (from module-init-tools) */ -static unsigned int tdb_hash(const char *name) +unsigned int tdb_hash(const char *name) { unsigned value; /* Used to compute the hash value. */ unsigned i; /* Used to cycle through random values. */ diff --git a/qdict.h b/qdict.h index 5e5902c..d221c18 100644 --- a/qdict.h +++ b/qdict.h @@ -59,4 +59,6 @@ int64_t qdict_get_try_int(const QDict *qdict, const char *key, int64_t err_value); const char *qdict_get_try_str(const QDict *qdict, const char *key); +/* Export tdb_hash() for use by trace framework */ +unsigned int tdb_hash(const char *name); #endif /* QDICT_H */ -- 1.6.2.5 -- Prerna Saxena Linux Technology Centre, IBM Systems and Technology Lab, Bangalore, India