qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Olivier Galibert <galibert@pobox.com>
To: qemu-devel <qemu-devel@nongnu.org>
Subject: [Qemu-devel] The bios loading in pc_memory_init doesn't seem to make sense
Date: Fri, 11 Jun 2010 10:16:36 +0200	[thread overview]
Message-ID: <20100611081635.GA11872@dspnet.fr> (raw)

  Hi all,

The bios loading part of pc_memory_init in hw/pc.c does not seem to
make sense.  Specifically, the operations are:
- find the bios file and its size, put the size in bios_size
- bios_offset = qemu_ram_alloc(bios_size)
- rom_add_file_fixed(bios_name, (uint32_t)(-bios_size))
  -> at this point raff() loads the file in an independant allocation
     and maps it at the end of the 4G space
- map up to 128K of bios_offset at 0xd0000
  -> notice that the bios file was never loaded in the ram allocated
     at bios_offset
- map bios_offset at end-of-4G
  -> same remark as before

So, since the emulation seems to work, what am I missing?

Best,

  OG.

                 reply	other threads:[~2010-06-11  8:16 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100611081635.GA11872@dspnet.fr \
    --to=galibert@pobox.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).