From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=35994 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1ONA6S-0002aC-50
	for qemu-devel@nongnu.org; Fri, 11 Jun 2010 15:41:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <paul@codesourcery.com>) id 1ONA6P-0001qi-KA
	for qemu-devel@nongnu.org; Fri, 11 Jun 2010 15:41:18 -0400
Received: from mail.codesourcery.com ([38.113.113.100]:52360)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <paul@codesourcery.com>) id 1ONA6P-0001qJ-DB
	for qemu-devel@nongnu.org; Fri, 11 Jun 2010 15:41:17 -0400
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH, applied] NEON vldN optimization
Date: Fri, 11 Jun 2010 20:40:12 +0100
References: <201006112015.56847.paul@codesourcery.com>
In-Reply-To: <201006112015.56847.paul@codesourcery.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201006112040.12528.paul@codesourcery.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

> +                            tcg_gen_shli_i32(tmp2, tmp, 16);
> +                            tcg_gen_or_i32(tmp, tmp, tmp2);

Which if you're paying attention is incorrect. Actual committed patch is 
correct -  tcg_gen_shli_i32(tmp2, tmp2, 16);

Paul