From: Aurelien Jarno <aurelien@aurel32.net>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] configure: Fix evaluation of config-host.mak in create_config
Date: Sat, 12 Jun 2010 16:37:58 +0200 [thread overview]
Message-ID: <20100612143758.GD1940@ohm.aurel32.net> (raw)
In-Reply-To: <4C137CA6.1020808@web.de>
On Sat, Jun 12, 2010 at 02:25:10PM +0200, Jan Kiszka wrote:
> Aurelien Jarno wrote:
> > On Fri, Jun 11, 2010 at 10:58:29PM +0200, Jan Kiszka wrote:
> >> From: Jan Kiszka <jan.kiszka@siemens.com>
> >>
> >> Only match on true dir variable assignments, avoid generating garbage
> >> due to the "# Configured with: ..." line which may contain "*dir=" as
> >> well.
> >
> > Wouldn't it be better to skip all lines starting with '#', as this
> > problem might happen again after some more changes?
> >
> > Or maybe we should do both.
>
> This is what the patch (implicitly) does.
Yes, but only for this line. What I mean is something more generic
like:
"#"*) # comment
continue
;;
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
next prev parent reply other threads:[~2010-06-12 15:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-11 20:58 [Qemu-devel] [PATCH] configure: Fix evaluation of config-host.mak in create_config Jan Kiszka
2010-06-12 11:55 ` Aurelien Jarno
2010-06-12 12:25 ` Jan Kiszka
2010-06-12 14:37 ` Aurelien Jarno [this message]
2010-06-12 16:44 ` Jan Kiszka
2010-06-12 17:57 ` [Qemu-devel] " Paolo Bonzini
2010-06-13 10:50 ` Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100612143758.GD1940@ohm.aurel32.net \
--to=aurelien@aurel32.net \
--cc=jan.kiszka@web.de \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).