From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=36833 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ONkvi-0008Rc-UE for qemu-devel@nongnu.org; Sun, 13 Jun 2010 07:00:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1ONkmR-00022E-2P for qemu-devel@nongnu.org; Sun, 13 Jun 2010 06:51:08 -0400 Received: from hall.aurel32.net ([88.191.82.174]:51627) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ONkmQ-000227-Sj for qemu-devel@nongnu.org; Sun, 13 Jun 2010 06:51:07 -0400 Date: Sun, 13 Jun 2010 12:50:59 +0200 From: Aurelien Jarno Subject: Re: [Qemu-devel] Re: [PATCH] configure: Fix evaluation of config-host.mak in create_config Message-ID: <20100613105059.GA30566@volta.aurel32.net> References: <4C12A375.6050201@web.de> <20100612115557.GK3008@ohm.aurel32.net> <4C137CA6.1020808@web.de> <20100612143758.GD1940@ohm.aurel32.net> <4C13B978.1000805@web.de> <4C13CAA0.70606@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <4C13CAA0.70606@redhat.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Jan Kiszka , qemu-devel On Sat, Jun 12, 2010 at 07:57:52PM +0200, Paolo Bonzini wrote: > On 06/12/2010 06:44 PM, Jan Kiszka wrote: > >>Yes, but only for this line. What I mean is something more generic > >>like: > >> > >>"#"*) # comment > >> continue > >> ;; > >> > > > >IMO, that would only paper over suboptimally expressed patterns for the > >other line evaluations. > > Agreed. I like Jan's patch more. > I have applied it. -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net