From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=40237 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1ONtIJ-0007Bj-4S
	for qemu-devel@nongnu.org; Sun, 13 Jun 2010 15:56:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <paul@codesourcery.com>) id 1ONtII-00084o-3W
	for qemu-devel@nongnu.org; Sun, 13 Jun 2010 15:56:34 -0400
Received: from mail.codesourcery.com ([38.113.113.100]:38999)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <paul@codesourcery.com>) id 1ONtIH-00084V-Nv
	for qemu-devel@nongnu.org; Sun, 13 Jun 2010 15:56:34 -0400
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] Re: [PATCH] pass info about hpets to seabios.
Date: Sun, 13 Jun 2010 20:55:23 +0100
References: <20100613144315.GB6292@redhat.com> <4C150DC5.6020802@web.de>
	<20100613171915.GA13238@redhat.com>
In-Reply-To: <20100613171915.GA13238@redhat.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201006132055.24141.paul@codesourcery.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Jan Kiszka <jan.kiszka@web.de>, Gleb Natapov <gleb@redhat.com>

> > And I think we can move the capability setup into init. But this is not
> > directly related to this patch, would just avoid adding this hunk to
> > hpet_reset.
> 
> I actually did that initially and tried to init hpet_cfg there too, but
> then noticed that mmio[0].addr below is not initialized at init time yet.
> 
> > > +    hpet_cfg.hpet.address = sysbus_from_qdev(d)->mmio[0].addr;

This is one of the reasons that you're not supposed to be messing with 
DeviceState contents directly.

Paul