From: Gleb Natapov <gleb@redhat.com>
To: Paul Brook <paul@codesourcery.com>
Cc: Jan Kiszka <jan.kiszka@web.de>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Re: [PATCH] pass info about hpets to seabios.
Date: Mon, 14 Jun 2010 08:18:28 +0300 [thread overview]
Message-ID: <20100614051828.GF6292@redhat.com> (raw)
In-Reply-To: <201006132055.24141.paul@codesourcery.com>
On Sun, Jun 13, 2010 at 08:55:23PM +0100, Paul Brook wrote:
> > > And I think we can move the capability setup into init. But this is not
> > > directly related to this patch, would just avoid adding this hunk to
> > > hpet_reset.
> >
> > I actually did that initially and tried to init hpet_cfg there too, but
> > then noticed that mmio[0].addr below is not initialized at init time yet.
> >
> > > > + hpet_cfg.hpet.address = sysbus_from_qdev(d)->mmio[0].addr;
>
> This is one of the reasons that you're not supposed to be messing with
> DeviceState contents directly.
>
Alternatives?
--
Gleb.
prev parent reply other threads:[~2010-06-14 5:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-13 14:43 [Qemu-devel] [PATCH] pass info about hpets to seabios Gleb Natapov
2010-06-13 16:56 ` [Qemu-devel] " Jan Kiszka
2010-06-13 17:19 ` Gleb Natapov
2010-06-13 17:41 ` Jan Kiszka
2010-06-13 19:02 ` Gleb Natapov
2010-06-13 19:55 ` Paul Brook
2010-06-14 5:18 ` Gleb Natapov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100614051828.GF6292@redhat.com \
--to=gleb@redhat.com \
--cc=jan.kiszka@web.de \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).