From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=45694 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OO24E-0005H1-S7 for qemu-devel@nongnu.org; Mon, 14 Jun 2010 01:18:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OO24D-0004h3-O6 for qemu-devel@nongnu.org; Mon, 14 Jun 2010 01:18:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:25514) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OO24D-0004gs-Ha for qemu-devel@nongnu.org; Mon, 14 Jun 2010 01:18:37 -0400 Date: Mon, 14 Jun 2010 08:18:28 +0300 From: Gleb Natapov Subject: Re: [Qemu-devel] Re: [PATCH] pass info about hpets to seabios. Message-ID: <20100614051828.GF6292@redhat.com> References: <20100613144315.GB6292@redhat.com> <4C150DC5.6020802@web.de> <20100613171915.GA13238@redhat.com> <201006132055.24141.paul@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201006132055.24141.paul@codesourcery.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Brook Cc: Jan Kiszka , qemu-devel@nongnu.org On Sun, Jun 13, 2010 at 08:55:23PM +0100, Paul Brook wrote: > > > And I think we can move the capability setup into init. But this is not > > > directly related to this patch, would just avoid adding this hunk to > > > hpet_reset. > > > > I actually did that initially and tried to init hpet_cfg there too, but > > then noticed that mmio[0].addr below is not initialized at init time yet. > > > > > > + hpet_cfg.hpet.address = sysbus_from_qdev(d)->mmio[0].addr; > > This is one of the reasons that you're not supposed to be messing with > DeviceState contents directly. > Alternatives? -- Gleb.