From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=55577 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OOArg-0002SW-UZ for qemu-devel@nongnu.org; Mon, 14 Jun 2010 10:42:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OOArf-0008C1-Pf for qemu-devel@nongnu.org; Mon, 14 Jun 2010 10:42:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:8896) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OOArf-0008Bn-HG for qemu-devel@nongnu.org; Mon, 14 Jun 2010 10:42:15 -0400 Date: Mon, 14 Jun 2010 11:42:07 -0300 From: Luiz Capitulino Message-ID: <20100614114207.414642d2@redhat.com> In-Reply-To: <4C163E48.7010108@linux.vnet.ibm.com> References: <20100609175215.2e2071a0@redhat.com> <20100611113022.27490bfe@redhat.com> <4C124A72.9000807@codemonkey.ws> <4C16357B.70308@linux.vnet.ibm.com> <20100614112414.1bead4ba@redhat.com> <4C163E48.7010108@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH v3 0/5] Add QMP migration events List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org, Juan Quintela On Mon, 14 Jun 2010 09:35:52 -0500 Anthony Liguori wrote: > On 06/14/2010 09:24 AM, Luiz Capitulino wrote: > > On Mon, 14 Jun 2010 08:58:19 -0500 > > Anthony Liguori wrote: > > > > > >> For 0.13, we need to focus on introducing the least disruptive change > >> that addresses the fundamental requirement--allow clients to avoid a > >> polling loop for determining when migration ends. Having a single event > >> with no payload is an extremely simple change. > >> > > Agreed. > > > > Actually, I'm slightly against introducing the done event too. While the > > polling is undesired, I don't think that having an event only for a release > > is worth it. > > > > I don't think we can realistically remove it. In my mind, what > deprecate means with respect to QMP is that we never add additional > features to the deprecated commands. Oh, by 'only for a release' I meant 'useful only for a release', ie. I didn't mean we would remove it but that it will only be useful for 0.13. > Right now, 'migrate', 'info migrate', and MIGRATE_DONE do not provide > very rich error reporting. They really just provide a boolean > failed/succeeded. > > For 0.14, we'll have to introduce a 'migrate2' command and deprecate the > old 'migrate' command. 'migrate2' will provide rich error reporting and > all new features will be added to 'migrate2'. > > BTW, I lack any kind of naming creativity so 'migrate2' is not > necessarily what it ought to be called. We can have a contest.