From: Kevin O'Connor <kevin@koconnor.net>
To: Gleb Natapov <gleb@redhat.com>
Cc: seabios@seabios.org, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [SeaBIOS] [PATCHv2] load hpet info for HPET ACPI table from qemu
Date: Mon, 14 Jun 2010 09:54:25 -0400 [thread overview]
Message-ID: <20100614135425.GA18002@morn.localdomain> (raw)
In-Reply-To: <20100614083053.GC21797@redhat.com>
On Mon, Jun 14, 2010 at 11:30:53AM +0300, Gleb Natapov wrote:
> Load hpet info for HPET ACPI table from qemu instead of using hardcoded
> values. Use hardcoded values anyway if old qemu is detected.
The current code does a lot of mixing of qemu provided and seabios
provided data to build the acpi tables. This patch extends that.
Unfortunately, I find it confusing because someone then needs to look
through both the seabios and qemu code to understand how the acpi
tables are generated.
Could we just have qemu build the hpet tables and pass them through to
seabios? Perhaps using the qemu_cfg_acpi_additional_tables() method.
-Kevin
next prev parent reply other threads:[~2010-06-14 13:54 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-14 8:30 [Qemu-devel] [PATCHv2] load hpet info for HPET ACPI table from qemu Gleb Natapov
2010-06-14 13:54 ` Kevin O'Connor [this message]
2010-06-14 14:09 ` [Qemu-devel] Re: [SeaBIOS] " Gleb Natapov
2010-06-14 14:40 ` Jamie Lokier
2010-06-14 16:03 ` Gleb Natapov
2010-06-14 14:51 ` Avi Kivity
2010-06-14 18:25 ` Kevin O'Connor
2010-06-14 18:56 ` Gleb Natapov
2010-06-14 20:12 ` Kevin O'Connor
2010-06-15 6:37 ` Gleb Natapov
2010-06-17 1:22 ` Kevin O'Connor
2010-06-17 7:45 ` Gleb Natapov
2010-06-17 1:58 ` Peter Stuge
2010-06-14 19:38 ` Anthony Liguori
2010-06-15 4:47 ` Avi Kivity
2010-06-15 6:50 ` Gleb Natapov
2010-06-17 1:47 ` Kevin O'Connor
2010-06-17 3:58 ` Avi Kivity
2010-06-17 6:57 ` Peter Stuge
2010-06-15 0:54 ` Paul Brook
2010-06-15 4:41 ` Avi Kivity
2010-06-17 0:55 ` Kevin O'Connor
2010-06-17 6:44 ` Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100614135425.GA18002@morn.localdomain \
--to=kevin@koconnor.net \
--cc=gleb@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=seabios@seabios.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).