From: "Michael S. Tsirkin" <mst@redhat.com>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: blauwirbel@gmail.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH 2/2] pci: don't overwrite pci header type.
Date: Tue, 15 Jun 2010 12:12:07 +0300 [thread overview]
Message-ID: <20100615091207.GA1365@redhat.com> (raw)
In-Reply-To: <ca619226f7c9d07f434d59df49b0a708d94e2071.1276573899.git.yamahata@valinux.co.jp>
On Tue, Jun 15, 2010 at 02:06:46PM +0900, Isaku Yamahata wrote:
> Don't overwrite pci header type.
> Otherwise, multi function bit which pci_init_header_type() sets
> appropriately is lost.
> Anyway PCI_HEADER_TYPE_NORMAL is zero, so it is unnecessary to zero
> which is already zero cleared.
>
> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
...
> diff --git a/hw/apb_pci.c b/hw/apb_pci.c
> index 31c8d70..cdf3bc2 100644
> --- a/hw/apb_pci.c
> +++ b/hw/apb_pci.c
> @@ -428,7 +428,8 @@ static int pbm_pci_host_init(PCIDevice *d)
> PCI_STATUS_DEVSEL_MEDIUM);
> pci_config_set_class(d->config, PCI_CLASS_BRIDGE_HOST);
> pci_set_byte(d->config + PCI_HEADER_TYPE,
> - PCI_HEADER_TYPE_NORMAL);
> + (pci_get_byte(d->config + PCI_HEADER_TYPE) &
> + PCI_HEADER_TYPE_MULTI_FUNCTION) | PCI_HEADER_TYPE_NORMAL);
what is this doing?
--
MST
next prev parent reply other threads:[~2010-06-15 9:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-15 5:06 [Qemu-devel] [PATCH 0/2] pci: multi-function bit fixes Isaku Yamahata
2010-06-15 5:06 ` [Qemu-devel] [PATCH 1/2] pci: set PCI multi-function bit appropriately Isaku Yamahata
2010-06-15 5:06 ` [Qemu-devel] [PATCH 2/2] pci: don't overwrite pci header type Isaku Yamahata
2010-06-15 9:12 ` Michael S. Tsirkin [this message]
2010-06-16 2:20 ` [Qemu-devel] " Isaku Yamahata
2010-06-16 8:54 ` Michael S. Tsirkin
2010-06-16 9:43 ` Isaku Yamahata
2010-06-16 11:19 ` Michael S. Tsirkin
2010-06-16 11:38 ` Isaku Yamahata
2010-06-16 12:43 ` Michael S. Tsirkin
2010-06-16 18:41 ` Blue Swirl
2010-06-16 18:51 ` Michael S. Tsirkin
2010-06-16 19:02 ` Blue Swirl
2010-06-16 19:22 ` Michael S. Tsirkin
2010-06-16 19:59 ` Blue Swirl
2010-06-16 20:12 ` Anthony Liguori
2010-06-15 9:42 ` [Qemu-devel] " malc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100615091207.GA1365@redhat.com \
--to=mst@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=yamahata@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).