From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=37641 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OOYZB-00069q-HA
	for qemu-devel@nongnu.org; Tue, 15 Jun 2010 12:00:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <hch@lst.de>) id 1OOYRB-0000NC-68
	for qemu-devel@nongnu.org; Tue, 15 Jun 2010 11:52:30 -0400
Received: from verein.lst.de ([213.95.11.210]:60553)
	by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from <hch@lst.de>)
	id 1OOYRA-0000Mq-Qx
	for qemu-devel@nongnu.org; Tue, 15 Jun 2010 11:52:29 -0400
Date: Tue, 15 Jun 2010 17:52:25 +0200
From: Christoph Hellwig <hch@lst.de>
Subject: Re: [Qemu-devel] [PATCH] block: fix physical_block_size calculation
Message-ID: <20100615155225.GA2364@lst.de>
References: <20100615123936.GA25281@lst.de> <4C1784AA.8080304@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4C1784AA.8080304@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>, qemu-devel@nongnu.org

> 512 looks wrong now that size is the number of logical blocks.

The patch is entirely wrong, and only happen to work for the case
I was testing by accident.  I'll resend a fixed version after I
created a little userspace test harness for all useful values.