From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=57771 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OOtVz-0000GJ-CK
	for qemu-devel@nongnu.org; Wed, 16 Jun 2010 10:22:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <jamie@shareable.org>) id 1OOtVy-0000F3-5Y
	for qemu-devel@nongnu.org; Wed, 16 Jun 2010 10:22:51 -0400
Received: from mail2.shareable.org ([80.68.89.115]:43982)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <jamie@shareable.org>) id 1OOtVy-0000Dr-1Z
	for qemu-devel@nongnu.org; Wed, 16 Jun 2010 10:22:50 -0400
Date: Wed, 16 Jun 2010 15:22:36 +0100
From: Jamie Lokier <jamie@shareable.org>
Subject: Re: [Qemu-devel] Re: [PATCH V4 2/3] qemu: Generic task offloading
	framework: threadlets
Message-ID: <20100616142236.GA20052@shareable.org>
References: <20100616115404.10988.62371.stgit@localhost.localdomain>
	<20100616115656.10988.96529.stgit@localhost.localdomain>
	<4C18C4C8.8090901@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4C18C4C8.8090901@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Gautham R Shenoy <ego@in.ibm.com>, Qemu-development List <qemu-devel@nongnu.org>, Anthony Liguori <aliguori@linux.vnet.ibm.com>, "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>, Corentin Chary <corentin.chary@gmail.com>, Avi Kivity <avi@redhat.com>

Paolo Bonzini wrote:
> These should be (at least for now) block-obj-$(CONFIG_POSIX).
> 
> >+        while (QTAILQ_EMPTY(&(queue->request_list))&&
> >+               (ret != ETIMEDOUT)) {
> >+            ret = qemu_cond_timedwait(&(queue->cond),
> >+					&(queue->lock), 10*100000);
> >+        }
> 
> Using qemu_cond_timedwait is a hack for not properly broadcasting the 
> condvar in flush_threadlet_queue.

Are you sure?  It looks like it also expires idle threads after a
fixed amount of idle time.

-- Jamie