From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=36820 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OOwbE-0001e1-1T for qemu-devel@nongnu.org; Wed, 16 Jun 2010 13:40:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OOwb9-0001GV-Pz for qemu-devel@nongnu.org; Wed, 16 Jun 2010 13:40:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:25353) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OOwb9-0001GG-FC for qemu-devel@nongnu.org; Wed, 16 Jun 2010 13:40:23 -0400 Date: Wed, 16 Jun 2010 14:40:08 -0300 From: Luiz Capitulino Message-ID: <20100616144008.50abd5d4@redhat.com> In-Reply-To: <1276205825-1922-4-git-send-email-miguel.filho@gmail.com> References: <1276205825-1922-1-git-send-email-miguel.filho@gmail.com> <1276205825-1922-4-git-send-email-miguel.filho@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 3/8] net: Introduce VLANClientState->info_dict List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Miguel Di Ciurcio Filho Cc: avi@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com On Thu, 10 Jun 2010 18:37:00 -0300 Miguel Di Ciurcio Filho wrote: > There is no standard format when formatting VLANClientState.info_str, > so it is difficult to extract information and transmit it over QMP. > > This patch adds info_dict, a QDict to better handle this information. > > Signed-off-by: Miguel Di Ciurcio Filho > --- > net.h | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/net.h b/net.h > index b83f615..acc1645 100644 > --- a/net.h > +++ b/net.h > @@ -66,6 +66,7 @@ struct VLANClientState { > char *model; > char *name; > char info_str[256]; > + QDict *info_dict; > unsigned receive_disabled : 1; > }; > You need to free it, you had a patch for that.