From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=55324 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OOwfx-0003yO-Qs
	for qemu-devel@nongnu.org; Wed, 16 Jun 2010 13:45:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <lcapitulino@redhat.com>) id 1OOwft-0002Dl-Cz
	for qemu-devel@nongnu.org; Wed, 16 Jun 2010 13:45:19 -0400
Received: from mx1.redhat.com ([209.132.183.28]:26153)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <lcapitulino@redhat.com>) id 1OOwft-0002De-6W
	for qemu-devel@nongnu.org; Wed, 16 Jun 2010 13:45:17 -0400
Date: Wed, 16 Jun 2010 14:44:57 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20100616144457.455387e4@redhat.com>
In-Reply-To: <1276205825-1922-1-git-send-email-miguel.filho@gmail.com>
References: <1276205825-1922-1-git-send-email-miguel.filho@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 0/8] QMP: Introduce query-netdev
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Miguel Di Ciurcio Filho <miguel.filho@gmail.com>
Cc: avi@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com

On Thu, 10 Jun 2010 18:36:57 -0300
Miguel Di Ciurcio Filho <miguel.filho@gmail.com> wrote:

> This series introduces the protocol specification for querying the backend
> network devices and a monitor command to show the same information.

 Please, add changelog info next time so that it's easier to know what has
changed since the last submission.

 General state looks good to me, most important point is to complete the
doc and get acks from spec reviewers (apart from fixing small issues, of course).

> 
> Patch 01 adds a new function qdict_to_qstring().
> 
> Patch 02 adds the documentation for query-netdev.
> 
> Patch 03 adds a new QDict member to VLANClientState named info_dict.
> 
> Patches 04-07 updates all devices to feed information into the new QDict
> info_dict.
> 
> Patch 08 implements do_info_netdev() for query-netdev and the monitor
> command 'info netdev'.
> 
> Regards,
> 
> Miguel
>