From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=52670 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OOvx6-00087u-2v
	for qemu-devel@nongnu.org; Wed, 16 Jun 2010 12:59:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <mtosatti@redhat.com>) id 1OOvu2-00013L-0s
	for qemu-devel@nongnu.org; Wed, 16 Jun 2010 12:55:51 -0400
Received: from mx1.redhat.com ([209.132.183.28]:6137)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <mtosatti@redhat.com>) id 1OOvu1-00012r-QP
	for qemu-devel@nongnu.org; Wed, 16 Jun 2010 12:55:49 -0400
Date: Wed, 16 Jun 2010 13:05:44 -0300
From: Marcelo Tosatti <mtosatti@redhat.com>
Message-ID: <20100616160544.GA3826@amt.cnet>
References: <1276231009-6060-1-git-send-email-sheng@linux.intel.com>
	<20100614203926.GA6316@amt.cnet> <4C18F25E.8070704@siemens.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4C18F25E.8070704@siemens.com>
Subject: [Qemu-devel] Re: [PATCH v3] qemu: kvm: Enable XSAVE live migration
	support
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, Avi Kivity <avi@redhat.com>, Sheng Yang <sheng@linux.intel.com>

On Wed, Jun 16, 2010 at 05:48:46PM +0200, Jan Kiszka wrote:
> Marcelo Tosatti wrote:
> > On Fri, Jun 11, 2010 at 12:36:49PM +0800, Sheng Yang wrote:
> >> Signed-off-by: Sheng Yang <sheng@linux.intel.com>
> >> ---
> >>  qemu-kvm-x86.c        |  109 ++++++++++++++++++++++++++++++++++++++++---------
> >>  qemu-kvm.c            |   24 +++++++++++
> >>  qemu-kvm.h            |   28 +++++++++++++
> >>  target-i386/cpu.h     |    5 ++
> >>  target-i386/kvm.c     |    2 +
> >>  target-i386/machine.c |   20 +++++++++
> >>  6 files changed, 169 insertions(+), 19 deletions(-)
> > 
> > Applied, thanks.
> 
> Oops, late remark: Why introducing this feature against qemu-kvm instead
> of upstream? Doesn't this just generate additional conversion work and
> the risk of divergence to upstream in the migration protocol?

Thats true. Sheng, can you add save/restore support to uq/master to
avoid these problems?

Then the cpuid bits can be also merged upstream.