From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=44874 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OOwUU-0006VU-K3
	for qemu-devel@nongnu.org; Wed, 16 Jun 2010 13:33:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <prvs=07836f6fe8=mjg59@cavan.codon.org.uk>)
	id 1OOwUK-0008P2-NL
	for qemu-devel@nongnu.org; Wed, 16 Jun 2010 13:33:22 -0400
Received: from cavan.codon.org.uk ([93.93.128.6]:39003)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <prvs=07836f6fe8=mjg59@cavan.codon.org.uk>)
	id 1OOwUK-0008Os-JL
	for qemu-devel@nongnu.org; Wed, 16 Jun 2010 13:33:20 -0400
Date: Wed, 16 Jun 2010 18:33:15 +0100
From: Matthew Garrett <mjg59@srcf.ucam.org>
Subject: Re: [Qemu-devel] Q35 qemu repository?
Message-ID: <20100616173315.GA29928@srcf.ucam.org>
References: <20100614135619.GA19671@srcf.ucam.org>
	<20100616024415.GC7932@valinux.co.jp>
	<20100616154210.GA26478@srcf.ucam.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20100616154210.GA26478@srcf.ucam.org>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: qemu-devel@nongnu.org

On Wed, Jun 16, 2010 at 04:42:10PM +0100, Matthew Garrett wrote:

> Thanks for this - however, Vista gives me an ACPI error on boot (stop 
> 0x000000a5, 0x0000000d, which indicates that there's a malformed or 
> undefined ACPI device). I don't suppose you have any idea what the 
> problem here may be? Linux boots without complaint.

Fixed with the following patch. Any devices with duplicate _HIDs require 
_UIDs.

diff --git a/src/q35-acpi-dsdt.dsl b/src/q35-acpi-dsdt.dsl
index ad05c7a..4697527 100644
--- a/src/q35-acpi-dsdt.dsl
+++ b/src/q35-acpi-dsdt.dsl
@@ -45,6 +45,7 @@ DefinitionBlock (
         Device (DBG0)
         {
             Name(_HID, EISAID("PNP0C02"))
+            Name(_UID, 0)
             Name(_CRS, ResourceTemplate() {
                 IO (Decode16, 0xb080, 0xb080, 0x00, 0x04)
             })
@@ -71,6 +72,7 @@ DefinitionBlock (
         Device(HP0)
         {
             Name(_HID, EISAID("PNP0C02"))
+            Name(_UID, 0x01)
             Name(_CRS, ResourceTemplate() {
                 IO (Decode16, 0xae00, 0xae00, 0x00, 0x0C)
                 IO (Decode16, 0xae0c, 0xae0c, 0x00, 0x01)

-- 
Matthew Garrett | mjg59@srcf.ucam.org