Re: [Qemu-devel] Q35 qemu repository?

[Isaku Yamahata <yamahata@valinux.co.jp>]

Thanks for the patch.
Does vista boot with the patch eventually?

On Wed, Jun 16, 2010 at 06:33:15PM +0100, Matthew Garrett wrote:
> On Wed, Jun 16, 2010 at 04:42:10PM +0100, Matthew Garrett wrote:
> 
> > Thanks for this - however, Vista gives me an ACPI error on boot (stop 
> > 0x000000a5, 0x0000000d, which indicates that there's a malformed or 
> > undefined ACPI device). I don't suppose you have any idea what the 
> > problem here may be? Linux boots without complaint.
> 
> Fixed with the following patch. Any devices with duplicate _HIDs require 
> _UIDs.
> 
> diff --git a/src/q35-acpi-dsdt.dsl b/src/q35-acpi-dsdt.dsl
> index ad05c7a..4697527 100644
> --- a/src/q35-acpi-dsdt.dsl
> +++ b/src/q35-acpi-dsdt.dsl
> @@ -45,6 +45,7 @@ DefinitionBlock (
>          Device (DBG0)
>          {
>              Name(_HID, EISAID("PNP0C02"))
> +            Name(_UID, 0)
>              Name(_CRS, ResourceTemplate() {
>                  IO (Decode16, 0xb080, 0xb080, 0x00, 0x04)
>              })
> @@ -71,6 +72,7 @@ DefinitionBlock (
>          Device(HP0)
>          {
>              Name(_HID, EISAID("PNP0C02"))
> +            Name(_UID, 0x01)
>              Name(_CRS, ResourceTemplate() {
>                  IO (Decode16, 0xae00, 0xae00, 0x00, 0x0C)
>                  IO (Decode16, 0xae0c, 0xae0c, 0x00, 0x01)
> 
> -- 
> Matthew Garrett | mjg59@srcf.ucam.org
> 

-- 
yamahata