From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=39093 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OPB9J-0000dJ-Ll for qemu-devel@nongnu.org; Thu, 17 Jun 2010 05:12:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OPB9F-0004Qg-Hz for qemu-devel@nongnu.org; Thu, 17 Jun 2010 05:12:37 -0400 Received: from e28smtp05.in.ibm.com ([122.248.162.5]:33634) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OPB9C-0004Pl-RI for qemu-devel@nongnu.org; Thu, 17 Jun 2010 05:12:33 -0400 Received: from d28relay01.in.ibm.com (d28relay01.in.ibm.com [9.184.220.58]) by e28smtp05.in.ibm.com (8.14.4/8.13.1) with ESMTP id o5H9CQ9k019692 for ; Thu, 17 Jun 2010 14:42:26 +0530 Received: from d28av04.in.ibm.com (d28av04.in.ibm.com [9.184.220.66]) by d28relay01.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o5H9CQRb872594 for ; Thu, 17 Jun 2010 14:42:26 +0530 Received: from d28av04.in.ibm.com (loopback [127.0.0.1]) by d28av04.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id o5H9CPHF021897 for ; Thu, 17 Jun 2010 19:12:26 +1000 Date: Thu, 17 Jun 2010 14:42:22 +0530 From: Gautham R Shenoy Subject: Re: [Qemu-devel] Re: [PATCH V4 2/3] qemu: Generic task offloading framework: threadlets Message-ID: <20100617091222.GB2849@in.ibm.com> References: <20100616115404.10988.62371.stgit@localhost.localdomain> <20100616115656.10988.96529.stgit@localhost.localdomain> <4C18C4C8.8090901@redhat.com> <20100616142236.GA20052@shareable.org> <4C18DFD7.1090102@redhat.com> <4C18E1E8.3030606@linux.vnet.ibm.com> <4C18E52B.9010600@redhat.com> <4C18EBC4.4040603@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4C18EBC4.4040603@linux.vnet.ibm.com> Reply-To: ego@in.ibm.com List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Qemu-development List , "Aneesh Kumar K.V" , Corentin Chary , Paolo Bonzini , Avi Kivity On Wed, Jun 16, 2010 at 10:20:36AM -0500, Anthony Liguori wrote: > On 06/16/2010 09:52 AM, Paolo Bonzini wrote: >> BTW it's obviously okay with signaling the condition when a threadlet is >> submitted. But when something affects all queue's workers >> (flush_threadlet_queue) you want a broadcast and using expiration as a >> substitute is fishy. > > IMHO, there shouldn't be a need for flush_threadlet_queue. It doesn't look > used in the aio conversion and if virtio-9p needs it, I suspect something > is wrong. virtio-9p doesn't need it. The API has been added for the vnc-server case, where a subsystem wants to wait on the threads of it's private queue to finish executing the already queued tasks. It's the responsibility of the subsystem to make sure that new tasks are not submitted during this interval. I sought clarification regarding this earlier, http://lists.gnu.org/archive/html/qemu-devel/2010-06/msg01382.html But now I am beginning to doubt I understood the use-case correctly. > > Regards, > > Anthony Liguori -- Thanks and Regards gautham