From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=38302 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OPCxr-0004Fu-EZ for qemu-devel@nongnu.org; Thu, 17 Jun 2010 07:08:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OPCxq-0001gL-2p for qemu-devel@nongnu.org; Thu, 17 Jun 2010 07:08:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:3698) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OPCxp-0001g6-R1 for qemu-devel@nongnu.org; Thu, 17 Jun 2010 07:08:54 -0400 Date: Thu, 17 Jun 2010 14:04:03 +0300 From: "Michael S. Tsirkin" Message-ID: <20100617110403.GA10552@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Subject: [Qemu-devel] [PATCH] vmware_vga: fix reset value for command register List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori , qemu-devel@nongnu.org Make init value for this register match the spec. BAR address is 0 at init, so enabling it only works by chance. Signed-off-by: Michael S. Tsirkin --- This patch is untested. Could someone who has vmware guests please look at it? Thanks! hw/vmware_vga.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/hw/vmware_vga.c b/hw/vmware_vga.c index bf2a699..41c959b 100644 --- a/hw/vmware_vga.c +++ b/hw/vmware_vga.c @@ -1240,9 +1240,6 @@ static int pci_vmsvga_initfn(PCIDevice *dev) pci_config_set_vendor_id(s->card.config, PCI_VENDOR_ID_VMWARE); pci_config_set_device_id(s->card.config, SVGA_PCI_DEVICE_ID); - s->card.config[PCI_COMMAND] = PCI_COMMAND_IO | - PCI_COMMAND_MEMORY | - PCI_COMMAND_MASTER; /* I/O + Memory */ pci_config_set_class(s->card.config, PCI_CLASS_DISPLAY_VGA); s->card.config[PCI_CACHE_LINE_SIZE] = 0x08; /* Cache line size */ s->card.config[PCI_LATENCY_TIMER] = 0x40; /* Latency timer */ -- 1.7.1.12.g42b7f