From: Luiz Capitulino <lcapitulino@redhat.com>
To: Miguel Di Ciurcio Filho <miguel.filho@gmail.com>
Cc: kwolf@redhat.com, clalance@redhat.com, qemu-devel@nongnu.org,
armbru@redhat.com
Subject: [Qemu-devel] Re: [PATCH v2] monitor: Really show snapshot information about all devices
Date: Thu, 17 Jun 2010 11:40:20 -0300 [thread overview]
Message-ID: <20100617114020.587d9745@redhat.com> (raw)
In-Reply-To: <1276779517-2974-1-git-send-email-miguel.filho@gmail.com>
On Thu, 17 Jun 2010 09:58:37 -0300
Miguel Di Ciurcio Filho <miguel.filho@gmail.com> wrote:
> The 'info snapshots' monitor command does not show snapshot information from all
> available block devices.
>
> Usage example:
> $ qemu -hda disk1.qcow2 -hdb disk2.qcow2
>
> (qemu) info snapshots
> Snapshot devices: ide0-hd0
> Snapshot list (from ide0-hd0):
> ID TAG VM SIZE DATE VM CLOCK
> 1 1.5M 2010-05-26 21:51:02 00:00:03.263
> 2 1.5M 2010-05-26 21:51:09 00:00:08.844
> 3 1.5M 2010-05-26 21:51:24 00:00:23.274
> 4 1.5M 2010-05-26 21:53:17 00:00:03.595
>
> In the above case, disk2.qcow2 has snapshot information, but it is not being
> shown. Only the first device is always shown.
>
> This patch updates the do_info_snapshots() function do correctly show snapshot
> information about all available block devices.
>
> New output:
> (qemu) info snapshots
> Snapshot list from ide0-hd0 (VM state image):
> ID TAG VM SIZE DATE VM CLOCK
> 1 1.5M 2010-05-26 21:51:02 00:00:03.263
> 2 1.5M 2010-05-26 21:51:09 00:00:08.844
> 3 1.5M 2010-05-26 21:51:24 00:00:23.274
> 4 1.5M 2010-05-26 21:53:17 00:00:03.595
>
> Snapshot list from ide0-hd1:
> ID TAG VM SIZE DATE VM CLOCK
> 1 0 2010-05-26 21:51:02 00:00:03.263
> 2 0 2010-05-26 21:51:09 00:00:08.844
> 3 0 2010-05-26 21:51:24 00:00:23.274
> 4 0 2010-05-26 21:53:17 00:00:03.595
I agree we need this info somewhere, but I'm wondering if this output won't
get users confused.
Perhaps it would be perfect to have 'info snapshots -a', but the user Monitor
don't support passing options to info commands.
Suggestions?
prev parent reply other threads:[~2010-06-17 14:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-17 12:58 [Qemu-devel] [PATCH v2] monitor: Really show snapshot information about all devices Miguel Di Ciurcio Filho
2010-06-17 14:40 ` Luiz Capitulino [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100617114020.587d9745@redhat.com \
--to=lcapitulino@redhat.com \
--cc=armbru@redhat.com \
--cc=clalance@redhat.com \
--cc=kwolf@redhat.com \
--cc=miguel.filho@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).