From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=52444 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OPDnZ-0007GF-Kh for qemu-devel@nongnu.org; Thu, 17 Jun 2010 08:02:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OPDnU-0003HR-V5 for qemu-devel@nongnu.org; Thu, 17 Jun 2010 08:02:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:11181) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OPDnU-0003Gy-Oc for qemu-devel@nongnu.org; Thu, 17 Jun 2010 08:02:16 -0400 Date: Thu, 17 Jun 2010 14:57:16 +0300 From: "Michael S. Tsirkin" Message-ID: <20100617115716.GA10827@redhat.com> References: <20100617100243.GF7912@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100617100243.GF7912@redhat.com> Subject: [Qemu-devel] Re: [PATCH 00/10] pci: pci to pci bridge clean up and enhancement List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Isaku Yamahata Cc: stefano.stabellini@eu.citrix.com, jan.kiszka@siemens.com, allen.m.kay@intel.com, qemu-devel@nongnu.org, blauwirbel@gmail.com, kraxel@redhat.com, jean.guyader@gmail.com On Thu, Jun 17, 2010 at 01:02:43PM +0300, Michael S. Tsirkin wrote: > For example, forcing all devices to call pci_reset_default > in their reset routines does not look like a good cleanup: > the less boilerplate, the better IMO. One thing that we need to address, is devices which need to enable memory+master on init. They should probably also enable this on reset. One approach that was discussed several times would be to call cleanup and then init again. I expect this would be enough to get rid of reset callbacks in most devices. -- MST