* [Qemu-devel] Re: [PATCH] virtio-pci: fix bus master bug setting on load
2010-06-17 15:15 [Qemu-devel] [PATCH] virtio-pci: fix bus master bug setting on load Alex Williamson
@ 2010-06-17 15:24 ` Michael S. Tsirkin
2010-06-17 15:57 ` Amit Shah
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Michael S. Tsirkin @ 2010-06-17 15:24 UTC (permalink / raw)
To: Alex Williamson; +Cc: amit.shah, qemu-devel, agraf
On Thu, Jun 17, 2010 at 09:15:02AM -0600, Alex Williamson wrote:
> The comment suggests we're checking for the driver in the ready
> state and bus master disabled, but the code is checking that it's
> not in the ready state.
>
> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
> Found-by: Amit Shah <amit.shah@redhat.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>
> hw/virtio-pci.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c
> index e101fa0..7a86a81 100644
> --- a/hw/virtio-pci.c
> +++ b/hw/virtio-pci.c
> @@ -155,7 +155,7 @@ static int virtio_pci_load_config(void * opaque, QEMUFile *f)
>
> /* Try to find out if the guest has bus master disabled, but is
> in ready state. Then we have a buggy guest OS. */
> - if (!(proxy->vdev->status & VIRTIO_CONFIG_S_DRIVER_OK) &&
> + if ((proxy->vdev->status & VIRTIO_CONFIG_S_DRIVER_OK) &&
> !(proxy->pci_dev.config[PCI_COMMAND] & PCI_COMMAND_MASTER)) {
> proxy->bugs |= VIRTIO_PCI_BUG_BUS_MASTER;
> }
^ permalink raw reply [flat|nested] 6+ messages in thread* [Qemu-devel] Re: [PATCH] virtio-pci: fix bus master bug setting on load
2010-06-17 15:15 [Qemu-devel] [PATCH] virtio-pci: fix bus master bug setting on load Alex Williamson
2010-06-17 15:24 ` [Qemu-devel] " Michael S. Tsirkin
@ 2010-06-17 15:57 ` Amit Shah
2010-06-17 16:01 ` Alexander Graf
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Amit Shah @ 2010-06-17 15:57 UTC (permalink / raw)
To: Alex Williamson; +Cc: mst, qemu-devel, agraf
On (Thu) Jun 17 2010 [09:15:02], Alex Williamson wrote:
> The comment suggests we're checking for the driver in the ready
> state and bus master disabled, but the code is checking that it's
> not in the ready state.
>
> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
> Found-by: Amit Shah <amit.shah@redhat.com>
> ---
Acked-by: Amit Shah <amit.shah@redhat.com>
Amit
^ permalink raw reply [flat|nested] 6+ messages in thread* [Qemu-devel] Re: [PATCH] virtio-pci: fix bus master bug setting on load
2010-06-17 15:15 [Qemu-devel] [PATCH] virtio-pci: fix bus master bug setting on load Alex Williamson
2010-06-17 15:24 ` [Qemu-devel] " Michael S. Tsirkin
2010-06-17 15:57 ` Amit Shah
@ 2010-06-17 16:01 ` Alexander Graf
2010-06-17 16:40 ` Juan Quintela
2010-06-23 1:48 ` [Qemu-devel] " Anthony Liguori
4 siblings, 0 replies; 6+ messages in thread
From: Alexander Graf @ 2010-06-17 16:01 UTC (permalink / raw)
To: Alex Williamson; +Cc: amit.shah, qemu-devel, mst
Alex Williamson wrote:
> The comment suggests we're checking for the driver in the ready
> state and bus master disabled, but the code is checking that it's
> not in the ready state.
>
> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
> Found-by: Amit Shah <amit.shah@redhat.com>
> ---
>
> hw/virtio-pci.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c
> index e101fa0..7a86a81 100644
> --- a/hw/virtio-pci.c
> +++ b/hw/virtio-pci.c
> @@ -155,7 +155,7 @@ static int virtio_pci_load_config(void * opaque, QEMUFile *f)
>
> /* Try to find out if the guest has bus master disabled, but is
> in ready state. Then we have a buggy guest OS. */
> - if (!(proxy->vdev->status & VIRTIO_CONFIG_S_DRIVER_OK) &&
> + if ((proxy->vdev->status & VIRTIO_CONFIG_S_DRIVER_OK) &&
>
Phew - that's an evil one. Thanks for the catch!
Acked-by: Alexander Graf <agraf@suse.de>
Alex
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Qemu-devel] Re: [PATCH] virtio-pci: fix bus master bug setting on load
2010-06-17 15:15 [Qemu-devel] [PATCH] virtio-pci: fix bus master bug setting on load Alex Williamson
` (2 preceding siblings ...)
2010-06-17 16:01 ` Alexander Graf
@ 2010-06-17 16:40 ` Juan Quintela
2010-06-23 1:48 ` [Qemu-devel] " Anthony Liguori
4 siblings, 0 replies; 6+ messages in thread
From: Juan Quintela @ 2010-06-17 16:40 UTC (permalink / raw)
To: Alex Williamson; +Cc: amit.shah, mst, qemu-devel, agraf
Alex Williamson <alex.williamson@redhat.com> wrote:
> The comment suggests we're checking for the driver in the ready
> state and bus master disabled, but the code is checking that it's
> not in the ready state.
>
> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
> Found-by: Amit Shah <amit.shah@redhat.com>
Acked-by: Juan Quintela <quintela@redhat.com>
> ---
>
> hw/virtio-pci.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c
> index e101fa0..7a86a81 100644
> --- a/hw/virtio-pci.c
> +++ b/hw/virtio-pci.c
> @@ -155,7 +155,7 @@ static int virtio_pci_load_config(void * opaque, QEMUFile *f)
>
> /* Try to find out if the guest has bus master disabled, but is
> in ready state. Then we have a buggy guest OS. */
> - if (!(proxy->vdev->status & VIRTIO_CONFIG_S_DRIVER_OK) &&
> + if ((proxy->vdev->status & VIRTIO_CONFIG_S_DRIVER_OK) &&
> !(proxy->pci_dev.config[PCI_COMMAND] & PCI_COMMAND_MASTER)) {
> proxy->bugs |= VIRTIO_PCI_BUG_BUS_MASTER;
> }
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Qemu-devel] [PATCH] virtio-pci: fix bus master bug setting on load
2010-06-17 15:15 [Qemu-devel] [PATCH] virtio-pci: fix bus master bug setting on load Alex Williamson
` (3 preceding siblings ...)
2010-06-17 16:40 ` Juan Quintela
@ 2010-06-23 1:48 ` Anthony Liguori
4 siblings, 0 replies; 6+ messages in thread
From: Anthony Liguori @ 2010-06-23 1:48 UTC (permalink / raw)
To: Alex Williamson; +Cc: amit.shah, mst, qemu-devel, agraf
On 06/17/2010 10:15 AM, Alex Williamson wrote:
> The comment suggests we're checking for the driver in the ready
> state and bus master disabled, but the code is checking that it's
> not in the ready state.
>
> Signed-off-by: Alex Williamson<alex.williamson@redhat.com>
> Found-by: Amit Shah<amit.shah@redhat.com>
>
Applied. Thanks.
Regards,
Anthony Liguori
> ---
>
> hw/virtio-pci.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c
> index e101fa0..7a86a81 100644
> --- a/hw/virtio-pci.c
> +++ b/hw/virtio-pci.c
> @@ -155,7 +155,7 @@ static int virtio_pci_load_config(void * opaque, QEMUFile *f)
>
> /* Try to find out if the guest has bus master disabled, but is
> in ready state. Then we have a buggy guest OS. */
> - if (!(proxy->vdev->status& VIRTIO_CONFIG_S_DRIVER_OK)&&
> + if ((proxy->vdev->status& VIRTIO_CONFIG_S_DRIVER_OK)&&
> !(proxy->pci_dev.config[PCI_COMMAND]& PCI_COMMAND_MASTER)) {
> proxy->bugs |= VIRTIO_PCI_BUG_BUS_MASTER;
> }
>
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread