From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=55655 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OPKYU-000807-1E for qemu-devel@nongnu.org; Thu, 17 Jun 2010 15:15:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OPKYS-0005fo-KL for qemu-devel@nongnu.org; Thu, 17 Jun 2010 15:15:13 -0400 Received: from fg-out-1718.google.com ([72.14.220.153]:13665) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OPKYS-0005fV-Ft for qemu-devel@nongnu.org; Thu, 17 Jun 2010 15:15:12 -0400 Received: by fg-out-1718.google.com with SMTP id 22so115121fge.10 for ; Thu, 17 Jun 2010 12:15:11 -0700 (PDT) Sender: Christian Brunner Date: Thu, 17 Jun 2010 21:15:08 +0200 From: Christian Brunner Message-ID: <20100617191508.GA1591@chb-desktop> References: <1275933621-404-1-git-send-email-morita.kazutaka@lab.ntt.co.jp> <4C123BAC.9080008@redhat.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="gKMricLos+KVdGMg" Content-Disposition: inline In-Reply-To: <4C123BAC.9080008@redhat.com> Subject: [Qemu-devel] Re: [PATCH v5] block: add sheepdog driver for distributed storage support List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: aliguori@us.ibm.com, sheepdog@lists.wpkg.org, chris.krumme@windriver.com, kvm@vger.kernel.org, qemu-devel@nongnu.org, MORITA Kazutaka --gKMricLos+KVdGMg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Jun 11, 2010 at 03:35:40PM +0200, Kevin Wolf wrote: > Am 07.06.2010 20:00, schrieb MORITA Kazutaka: > > Also, I'd like to have qemu-iotests run on it before including it. IIRC, > Christian has hacked on qemu-iotests to make it work with protocols for > his rbd driver - Christian, can you provide us with your changes, so > that they can be used for Sheepdog, too? Or if they are not too hacky, > maybe you can even post them for inclusion in qemu-iotests? > Attached is a patch to make qemu-iotests work with the rbd driver. However this is only a very basic hack for the rbd driver and not a generic patch for protocol support. If you want, I can try to make it a bit more versatile. hristian --gKMricLos+KVdGMg Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0001-a-small-hack-to-run-tests-aginst-the-rbd-driver.patch" >>From 17031ac88d05b4796dc1f231317d843f26f1a331 Mon Sep 17 00:00:00 2001 From: Christian Brunner Date: Thu, 3 Jun 2010 21:05:24 +0200 Subject: [PATCH] a small hack to run tests aginst the rbd driver --- common | 6 ++++++ common.rc | 14 +++++++++++--- 2 files changed, 17 insertions(+), 3 deletions(-) diff --git a/common b/common index 988fd5e..df4e6c9 100644 --- a/common +++ b/common @@ -122,6 +122,7 @@ check options -vdi test vdi -vpc test vpc -vmdk test vmdk + -rbd test rbd -xdiff graphical mode diff -nocache use O_DIRECT on backing file -misalign misalign memory allocations @@ -173,6 +174,11 @@ testlist options xpand=false ;; + -rbd) + IMGFMT=rbd + xpand=false + ;; + -nocache) QEMU_IO_OPTIONS="$QEMU_IO_OPTIONS --nocache" xpand=false diff --git a/common.rc b/common.rc index da58f92..2bde819 100644 --- a/common.rc +++ b/common.rc @@ -47,6 +47,10 @@ fi # make sure we have a standard umask umask 022 +if [ "$IMGFMT" = "rbd" ]; then + TEST_DIR=rbd:rbd +fi + TEST_IMG=$TEST_DIR/t.$IMGFMT _make_test_img() @@ -71,9 +75,13 @@ _make_test_img() _cleanup_test_img() { - rm -f $TEST_DIR/t.$IMGFMT - rm -f $TEST_DIR/t.$IMGFMT.orig - rm -f $TEST_DIR/t.$IMGFMT.base + if [ "$IMGFMT" = "rbd" ]; then + rbdtool --delete t.$IMGFMT + else + rm -f $TEST_DIR/t.$IMGFMT + rm -f $TEST_DIR/t.$IMGFMT.orig + rm -f $TEST_DIR/t.$IMGFMT.base + fi } _check_test_img() -- 1.7.0.4 --gKMricLos+KVdGMg--