From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=48582 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OPdOi-0005q3-NX for qemu-devel@nongnu.org; Fri, 18 Jun 2010 11:22:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OPdOh-0001jd-Ew for qemu-devel@nongnu.org; Fri, 18 Jun 2010 11:22:24 -0400 Received: from mail2.shareable.org ([80.68.89.115]:46667) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OPdOh-0001jQ-Ax for qemu-devel@nongnu.org; Fri, 18 Jun 2010 11:22:23 -0400 Date: Fri, 18 Jun 2010 16:22:11 +0100 From: Jamie Lokier Subject: Re: [Qemu-devel] Re: [PATCH 09/10] pci: set PCI multi-function bit appropriately. Message-ID: <20100618152210.GA10919@shareable.org> References: <81d134b49ddbd54e82648618c0ce4e4d11fb77c3.1276755023.git.yamahata@valinux.co.jp> <20100617093721.GB7912@redhat.com> <20100618024057.GC14658@valinux.co.jp> <20100618124404.GA6397@redhat.com> <20100618133820.GF28863@valinux.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100618133820.GF28863@valinux.co.jp> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Isaku Yamahata Cc: stefano.stabellini@eu.citrix.com, jan.kiszka@siemens.com, "Michael S. Tsirkin" , allen.m.kay@intel.com, qemu-devel@nongnu.org, blauwirbel@gmail.com, kraxel@redhat.com, jean.guyader@gmail.com Isaku Yamahata wrote: > On Fri, Jun 18, 2010 at 03:44:04PM +0300, Michael S. Tsirkin wrote: > > If we really want the ability to put unrelated devices > > as functions in a single one, let's just add > > a 'multifunction' qdev property, and validate that > > it is set appropriately. > > I think "unrelated" is policy. There is no obvious way to determine > which functions can be in a same device. > For example, popular chipset contains isa bridge, ide controller, > usb controller, sound and modem in a single device as functions. > It's up to hardware designer policy which functions are grouped into > a device. In hardware terms, quad-port ethernet controllers often present themselves as a PCI bridge with four independent PCI ethernet controllers, so they work with standard drivers. Even though all four are in a single chip. Some USB devices do the same, presenting a small bulk storage device to ship windows drivers [:roll-eyes: ;-)] alongside the actual device. -- Jamie