From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=42964 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OPiMs-0004XQ-OC for qemu-devel@nongnu.org; Fri, 18 Jun 2010 16:40:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OPiMQ-0007EO-Dd for qemu-devel@nongnu.org; Fri, 18 Jun 2010 16:40:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:11065) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OPiMQ-0007EC-5p for qemu-devel@nongnu.org; Fri, 18 Jun 2010 16:40:22 -0400 Date: Fri, 18 Jun 2010 17:40:13 -0300 From: Luiz Capitulino Subject: Re: [Qemu-devel] [PATCH v2] QMP: Introduce the documentation for query-netdev and info netdev Message-ID: <20100618174013.08e5bbdc@redhat.com> In-Reply-To: <4C1BD6FA.7020502@codemonkey.ws> References: <1276878387-9489-1-git-send-email-miguel.filho@gmail.com> <4C1BD6FA.7020502@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: avi@redhat.com, Miguel Di Ciurcio Filho , qemu-devel@nongnu.org, armbru@redhat.com On Fri, 18 Jun 2010 15:28:42 -0500 Anthony Liguori wrote: > On 06/18/2010 11:26 AM, Miguel Di Ciurcio Filho wrote: > > These commands show the information about active backend network devices. > > > > Signed-off-by: Miguel Di Ciurcio Filho > > --- > > qemu-monitor.hx | 105 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > 1 files changed, 105 insertions(+), 0 deletions(-) > > > > diff --git a/qemu-monitor.hx b/qemu-monitor.hx > > index 9f62b94..8fc5ed6 100644 > > --- a/qemu-monitor.hx > > +++ b/qemu-monitor.hx > > @@ -1674,6 +1674,111 @@ show the various VLANs and the associated devices > > ETEXI > > > > STEXI > > +@item info netdev > > +show information about the current backend network devices > > +ETEXI > > +SQMP > > +query-netdev > > +------------ > > + > > +Each device is represented by a json-object. The returned value is a json-array > > +of all devices. > > + > > +Each json-object contains the following: > > + > > +- "id": the device's ID, must be unique (json-string) > > +- "type": device type (json-string) > > + - Possible values: "tap", "user", "vde", "socket" > > +- "vlan": QEMU's internal vlan identification. Only present if the device is > > + attached to a VLAN (json-int, optional) > > +- "peer": ID of the frontend device when on a 1:1 relationship (json-string, > > + optional) > > > > I think we should only return items with a valid peer property and drop > anything attached to vlans. The reason is that we're going to completely drop the vlan stuff, right? > The current info network already provides vlan information. What did you mean by that? info network is not going to be converted to QMP, that's why we're doing query-netdev. If I got it right: - query-netdev: backend info - query-qdm: device info