qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Isaku Yamahata <yamahata@valinux.co.jp>
To: qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] pci hotplug: staticfy pci_device_hot_remove().
Date: Mon, 21 Jun 2010 18:54:22 +0900	[thread overview]
Message-ID: <20100621095422.GD18250@valinux.co.jp> (raw)
In-Reply-To: <20100615034836.GU23473@valinux.co.jp>

Ping.
Michael, do you have any comment on this?

On Tue, Jun 15, 2010 at 12:48:36PM +0900, Isaku Yamahata wrote:
> staticfy pci_device_hot_remove().
> 
> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
> ---
>  hw/pci-hotplug.c |    2 +-
>  sysemu.h         |    1 -
>  2 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/pci-hotplug.c b/hw/pci-hotplug.c
> index c39e640..098264c 100644
> --- a/hw/pci-hotplug.c
> +++ b/hw/pci-hotplug.c
> @@ -258,7 +258,7 @@ void pci_device_hot_add(Monitor *mon, const QDict *qdict)
>  }
>  #endif
>  
> -int pci_device_hot_remove(Monitor *mon, const char *pci_addr)
> +static int pci_device_hot_remove(Monitor *mon, const char *pci_addr)
>  {
>      PCIDevice *d;
>      int dom, bus;
> diff --git a/sysemu.h b/sysemu.h
> index c758243..9c988bb 100644
> --- a/sysemu.h
> +++ b/sysemu.h
> @@ -149,7 +149,6 @@ extern unsigned int nb_prom_envs;
>  /* pci-hotplug */
>  void pci_device_hot_add(Monitor *mon, const QDict *qdict);
>  void drive_hot_add(Monitor *mon, const QDict *qdict);
> -int pci_device_hot_remove(Monitor *mon, const char *pci_addr);
>  void do_pci_device_hot_remove(Monitor *mon, const QDict *qdict);
>  
>  /* serial ports */
> -- 
> 1.6.6.1
> 
> 

-- 
yamahata

  parent reply	other threads:[~2010-06-21  9:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-15  3:48 [Qemu-devel] [PATCH] pci hotplug: staticfy pci_device_hot_remove() Isaku Yamahata
2010-06-15  8:58 ` [Qemu-devel] " Gerd Hoffmann
2010-06-21  9:54 ` Isaku Yamahata [this message]
2010-06-21 11:37 ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100621095422.GD18250@valinux.co.jp \
    --to=yamahata@valinux.co.jp \
    --cc=kraxel@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).