From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=52501 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ORhkR-00045T-63 for qemu-devel@nongnu.org; Thu, 24 Jun 2010 04:25:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1ORhk0-0001Pn-Lb for qemu-devel@nongnu.org; Thu, 24 Jun 2010 04:24:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50085) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ORhk0-0001Pc-Bx for qemu-devel@nongnu.org; Thu, 24 Jun 2010 04:24:56 -0400 Date: Thu, 24 Jun 2010 11:19:39 +0300 From: "Michael S. Tsirkin" Subject: Re: [Qemu-devel] Re: [PATCH v4 3/6] pci: set PCI multi-function bit appropriately. Message-ID: <20100624081939.GB937@redhat.com> References: <99d849f1b4eeb12893447e78a6950c26a32088ac.1277100005.git.yamahata@valinux.co.jp> <20100621123600.GB10511@redhat.com> <20100623072520.GC3471@valinux.co.jp> <20100623095210.GA9802@redhat.com> <20100623101338.GD3471@valinux.co.jp> <20100623104157.GA19664@redhat.com> <20100623234842.GG3471@valinux.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100623234842.GG3471@valinux.co.jp> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Isaku Yamahata Cc: blauwirbel@gmail.com, yu.liu@freescale.com, qemu-devel@nongnu.org, aurelien@aurel32.net, paul@codesourcery.com On Thu, Jun 24, 2010 at 08:48:42AM +0900, Isaku Yamahata wrote: > On Wed, Jun 23, 2010 at 01:41:57PM +0300, Michael S. Tsirkin wrote: > > I will try to find a bit of time to rearrange the code in pci.c a bit, > > but this can come afterwards. > > I'd like to move pci_bridge_xxx into pci_bridge.c because > pci.c has grown. > Are you okay with it? Or should I wait for your rearrange? > I'd like to avoid stepping on each other. I'm looking at rearranging it myself, but doing some API cleanup first. It will be easier if you keep adding to pci.c meanwhile. > -- > yamahata