From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=51100 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1ORuHP-00062Y-Aj
	for qemu-devel@nongnu.org; Thu, 24 Jun 2010 17:48:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <lcapitulino@redhat.com>) id 1ORuHO-0003Y4-7k
	for qemu-devel@nongnu.org; Thu, 24 Jun 2010 17:48:15 -0400
Received: from mx1.redhat.com ([209.132.183.28]:19057)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <lcapitulino@redhat.com>) id 1ORuHN-0003Xv-W4
	for qemu-devel@nongnu.org; Thu, 24 Jun 2010 17:48:14 -0400
Received: from int-mx03.intmail.prod.int.phx2.redhat.com
	(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o5OLmC6M018693
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Thu, 24 Jun 2010 17:48:13 -0400
Date: Thu, 24 Jun 2010 18:48:08 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 00/14]: QMP: Replace client argument
	checker
Message-ID: <20100624184808.57dd70d9@redhat.com>
In-Reply-To: <1277415220-17810-1-git-send-email-lcapitulino@redhat.com>
References: <1277415220-17810-1-git-send-email-lcapitulino@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: armbru@redhat.com

On Thu, 24 Jun 2010 18:33:26 -0300
Luiz Capitulino <lcapitulino@redhat.com> wrote:

> Current QMP's client argument checker code is more complex than it should be
> and has a flaw: it ignores unknown arguments.
> 
> This series solves both problems by introducing a new, simple and ultra-poweful
> argument checker. This wasn't trivial to get right due to the number of errors
> combinations, so review is very appreciated.
> 
> changelog
> ---------
> 
> v2 -> v3
> 
> - Move all input object checking into qmp_check_input_obj()
> - Fix remaining problem with the handling of O-type arguments
> - Small renames suggested by Markus
> - Small cleanup in handle_qmp_command()

Forgot to mention that changes from v2 begin in patch 08, and really relevant
ones in patch 12.

> 
> v1 -> v2
> 
> - Introduce new iteration API and use it
> - Handle O-type correctly (I hope so)
> - Address several small issues found by Markus
>