From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=44939 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OSEkm-0001N9-6O
	for qemu-devel@nongnu.org; Fri, 25 Jun 2010 15:39:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <hch@lst.de>) id 1OSEkk-0005g8-2Z
	for qemu-devel@nongnu.org; Fri, 25 Jun 2010 15:39:55 -0400
Received: from verein.lst.de ([213.95.11.210]:44354)
	by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from <hch@lst.de>)
	id 1OSEkj-0005fw-N0
	for qemu-devel@nongnu.org; Fri, 25 Jun 2010 15:39:54 -0400
Date: Fri, 25 Jun 2010 21:39:52 +0200
From: Christoph Hellwig <hch@lst.de>
Message-ID: <20100625193952.GA2865@lst.de>
References: <1277484812-22012-1-git-send-email-armbru@redhat.com>
	<1277484812-22012-2-git-send-email-armbru@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1277484812-22012-2-git-send-email-armbru@redhat.com>
Subject: [Qemu-devel] Re: [PATCH 01/12] scsi:
	scsi_bus_legacy_handle_cmdline() can fail, fix callers
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: kwolf@redhat.com, hch@lst.de, qemu-devel@nongnu.org, kraxel@redhat.com

On Fri, Jun 25, 2010 at 06:53:21PM +0200, Markus Armbruster wrote:
> None of its callers checks for failure.  scsi_hot_add() can crash
> because of that:
> 
> (qemu) drive_add 4 if=scsi,format=host_device,file=/dev/sg1
> scsi-generic: scsi generic interface too old
> Segmentation fault (core dumped)
> 
> Fix all callers, not just scsi_hot_add().

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>