From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=45022 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OSEl7-0001Z6-3r for qemu-devel@nongnu.org; Fri, 25 Jun 2010 15:40:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OSEl5-0005l3-RS for qemu-devel@nongnu.org; Fri, 25 Jun 2010 15:40:16 -0400 Received: from verein.lst.de ([213.95.11.210]:44361) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OSEl5-0005kq-HB for qemu-devel@nongnu.org; Fri, 25 Jun 2010 15:40:15 -0400 Date: Fri, 25 Jun 2010 21:40:14 +0200 From: Christoph Hellwig Message-ID: <20100625194014.GB2865@lst.de> References: <1277484812-22012-1-git-send-email-armbru@redhat.com> <1277484812-22012-3-git-send-email-armbru@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1277484812-22012-3-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] Re: [PATCH 02/12] ide: Make it explicit that ide_create_drive() can't fail List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: kwolf@redhat.com, hch@lst.de, qemu-devel@nongnu.org, kraxel@redhat.com On Fri, Jun 25, 2010 at 06:53:22PM +0200, Markus Armbruster wrote: > All callers of ide_create_drive() ignore its value. Currently > harmless, because it fails only when qdev_init() fails, which fails > only when ide_drive_initfn() fails, which never fails. > > Brittle. Change it to die instead of silently ignoring failure. > > Signed-off-by: Markus Armbruster Looks good, Reviewed-by: Christoph Hellwig