From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=59693 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OSRyV-0005HJ-U0
	for qemu-devel@nongnu.org; Sat, 26 Jun 2010 05:47:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <hch@lst.de>) id 1OSRyU-0008DU-Pt
	for qemu-devel@nongnu.org; Sat, 26 Jun 2010 05:46:59 -0400
Received: from verein.lst.de ([213.95.11.210]:48002)
	by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from <hch@lst.de>)
	id 1OSRyU-0008C6-H4
	for qemu-devel@nongnu.org; Sat, 26 Jun 2010 05:46:58 -0400
Date: Sat, 26 Jun 2010 11:46:50 +0200
From: Christoph Hellwig <hch@lst.de>
Message-ID: <20100626094650.GA26793@lst.de>
References: <1277484812-22012-1-git-send-email-armbru@redhat.com>
	<1277484812-22012-5-git-send-email-armbru@redhat.com>
	<20100625194201.GD2865@lst.de>
	<m38w622wbq.fsf@blackfin.pond.sub.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <m38w622wbq.fsf@blackfin.pond.sub.org>
Subject: [Qemu-devel] Re: [PATCH 04/12] blockdev: New drive_of_blockdev()
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: kwolf@redhat.com, kraxel@redhat.com, Christoph Hellwig <hch@lst.de>, qemu-devel@nongnu.org

On Sat, Jun 26, 2010 at 07:32:09AM +0200, Markus Armbruster wrote:
> Christoph Hellwig <hch@lst.de> writes:
> 
> >> +DriveInfo *drive_of_blockdev(BlockDriverState *bs)
> >
> > I'd call this find_drive_by_blockdev.
> 
> For what it's worth, all externally visible functions dealing with
> drives start with "drive_".

Ok.  How about drive_get_by_blockdev, matching the drive_get_by_id we
have around?