From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=60717 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OSSKM-0000tQ-44 for qemu-devel@nongnu.org; Sat, 26 Jun 2010 06:09:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OSSKK-0002Nv-Bp for qemu-devel@nongnu.org; Sat, 26 Jun 2010 06:09:33 -0400 Received: from verein.lst.de ([213.95.11.210]:37431) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OSSKK-0002Nh-0W for qemu-devel@nongnu.org; Sat, 26 Jun 2010 06:09:32 -0400 Date: Sat, 26 Jun 2010 12:09:29 +0200 From: Christoph Hellwig Message-ID: <20100626100929.GA27699@lst.de> References: <1277484812-22012-1-git-send-email-armbru@redhat.com> <1277484812-22012-7-git-send-email-armbru@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1277484812-22012-7-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] Re: [PATCH 06/12] qdev: Decouple qdev_prop_drive from DriveInfo List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: kwolf@redhat.com, hch@lst.de, qemu-devel@nongnu.org, kraxel@redhat.com On Fri, Jun 25, 2010 at 06:53:26PM +0200, Markus Armbruster wrote: > Make the property point to BlockDriverState, cutting out the DriveInfo > middleman. This prepares the ground for block devices that don't have > a DriveInfo. > > Currently all user-defined ones have a DriveInfo, because the only way > to define one is -drive & friends (they go through drive_init()). > DriveInfo is closely tied to -drive, and like -drive, it mixes > information about host and guest part of the block device. I'm > working towards a new way to define block devices, with clean > host/guest separation, and I need to get DriveInfo out of the way for > that. > > Fortunately, the device models are perfectly happy with > BlockDriverState, except for two places: ide_drive_initfn() and > scsi_disk_initfn() need to check the DriveInfo for a serial number set > with legacy -drive serial=... Use drive_of_blockdev() there. > > Device model code should now use DriveInfo only when explicitly > dealing with drives defined the old way, i.e. without -device. This looks good to me. Assuming the size change of the property can't cause any problems: Reviewed-by: Christoph Hellwig